Fix test_ros_loader.py

[kenji-miyake]

Public Changes

None

Description

Fixed test_ros_loader.py to pass the tests.

$ colcon test --event-handlers console_cohesion+ --packages-select rosbridge_library
Starting >>> rosbridge_library
--- output: rosbridge_library                   
UpdateCTestConfiguration  from :/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/CTestConfiguration.ini
Parse Config file:/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/CTestConfiguration.ini
   Site: desktop
   Build name: (empty)
 Add coverage exclude regular expressions.
SetCTestConfiguration:CMakeCommand:/usr/bin/cmake
Create new tag: 20210924-1456 - Experimental
UpdateCTestConfiguration  from :/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/CTestConfiguration.ini
Parse Config file:/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/CTestConfiguration.ini
Test project /home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 1
    Start 1: test_ros_loader

1: Test command: /usr/bin/python3 "-u" "/opt/ros/galactic/share/ament_cmake_test/cmake/run_test.py" "/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/test_results/rosbridge_library/test_ros_loader.xunit.xml" "--package-name" "rosbridge_library" "--output-file" "/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/ament_cmake_pytest/test_ros_loader.txt" "--command" "/usr/bin/python3" "-u" "-m" "pytest" "/home/kenji/ghq/github.com/tier4/rosbridge_suite/rosbridge_library/test/internal/test_ros_loader.py" "-o" "cache_dir=/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/ament_cmake_pytest/test_ros_loader/.cache" "--junit-xml=/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/test_results/rosbridge_library/test_ros_loader.xunit.xml" "--junit-prefix=rosbridge_library"
1: Test timeout computed to be: 60
1: -- run_test.py: invoking following command in '/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library':
1:  - /usr/bin/python3 -u -m pytest /home/kenji/ghq/github.com/tier4/rosbridge_suite/rosbridge_library/test/internal/test_ros_loader.py -o cache_dir=/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/ament_cmake_pytest/test_ros_loader/.cache --junit-xml=/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/test_results/rosbridge_library/test_ros_loader.xunit.xml --junit-prefix=rosbridge_library
1: ============================= test session starts ==============================
1: platform linux -- Python 3.8.10, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
1: cachedir: build/rosbridge_library/ament_cmake_pytest/test_ros_loader/.cache
1: rootdir: /home/kenji/ghq/github.com/tier4/rosbridge_suite
1: plugins: ament-lint-0.10.6, ament-pep257-0.10.6, launch-testing-0.17.0, ament-copyright-0.10.6, ament-xmllint-0.10.6, launch-testing-ros-0.14.2, ament-flake8-0.10.6, cov-2.12.1, asyncio-0.15.1, rerunfailures-10.1, repeat-0.9.1, dash-2.0.0, mock-1.10.4, colcon-core-0.6.1
1: collected 16 items
1: 
1: ../../rosbridge_library/test/internal/test_ros_loader.py ............... [ 93%]
1: .                                                                        [100%]
1: 
1: - generated xml file: /home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/test_results/rosbridge_library/test_ros_loader.xunit.xml -
1: ============================== 16 passed in 0.28s ==============================
1: -- run_test.py: return code 0
1: -- run_test.py: verify result file '/home/kenji/ghq/github.com/tier4/rosbridge_suite/build/rosbridge_library/test_results/rosbridge_library/test_ros_loader.xunit.xml'
1/1 Test #1: test_ros_loader ..................   Passed    1.10 sec

100% tests passed, 0 tests failed out of 1

Label Time Summary:
pytest    =   1.10 sec*proc (1 test)

Total Test time (real) =   1.10 sec
---
Finished <<< rosbridge_library [1.16s]

Summary: 1 package finished [1.30s]

Related: #643

[amacneil]

thanks! needs rebase before merging

[kenji-miyake]

@amacneil Thank you for your review! Resolved conflicts instead of rebasing.

[jtbandes]

Suggesting some changes in tier4#11

[kenji-miyake]

@jtbandes Thank you, I merged your change.

[jtbandes]

I guess I forgot to fix lint errors after my change, sorry :)

[kenji-miyake]

Rebased to import the latest changes.

[jtbandes]

Can you please rebase on #686 ? These newly added tests were not running in CI, and they might need more changes to be able to pass CI.

[kenji-miyake]

@jtbandes Rebased and the test passed except for rolling.
https://github.com/RobotWebTools/rosbridge_suite/runs/4479225984?check_suite_focus=true

[jtbandes]

Thanks, it passed after I re-ran the job. I guess the test is just a little bit flaky.