-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkerClient: Subscribe to MarkerArray topic #74
Conversation
MarkerClient will now automatically subscribe to the topic provided in the constructor, *and* <topicname>_array
Would it make more sense for this to live in its own object type? e.g., MarkerArrayClient. Currently, this will subscribe to both a marker and marker array topic on the same client, when one or the other might not even exist. |
It would be simple enough to make a MarkerArrayClient, but the RViz Marker Plugin also subscribes to both the regular and the |
Good point :) I've moved the functionality into |
Looks good! 🍰 |
MarkerClient: Subscribe to MarkerArray topic
Thanks @T045T ! |
that.emit('change'); | ||
}); | ||
}; | ||
ROS3D.MarkerClient.prototype.__proto__ = EventEmitter2.prototype; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this line be
ROS3D.MarkerArrayClient.prototype.__proto__ = EventEmitter2.prototype;
?
I'm currently getting
Uncaught TypeError: Cannot read property 'prototype' of undefined
on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course. It's fixed now, sorry about that.
Fixes #73