Improve Python 3.11 support #60
Conversation
Backport of pybind#3694
equivalent of RobotLocomotion/pybind11#60
equivalent of RobotLocomotion/pybind11#60
equivalent of RobotLocomotion/pybind11#60
equivalent of RobotLocomotion/pybind11#60
There was a problem hiding this comment.
CC @jwnimmer-tri for review please (I don't have perms to assign on this repo). Drake PR that ran CI against this: RobotLocomotion/drake#18262
Specifically:
- Existing linux wheel works as expected (test patch doesn't break prior python)
- mac arm wheel build with 3.11 works
- mac x86_64 wheel build with 3.11 works
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @svenevs)
|
Please open a Drake PR that has the sha bump for pybind11 to this PR, and launch a full CI run there (in particular, with 3.10 still on macOS). |
There was a problem hiding this comment.
LGTM pending Drake CI.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @svenevs)
-- commits line 4 at r1:
nit To my first reading, you didn't need to adjust the patch at all, you took it straight as-is with no merge conflicts. If so, that's a cherry-pick, not a backport.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jwnimmer-tri)
a discussion (no related file):
Working,
Please open a Drake PR that has the sha bump for pybind11 to this PR, and launch a full CI run there (in particular, with 3.10 still on macOS).
=> RobotLocomotion/drake#18297
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit To my first reading, you didn't need to adjust the patch at all, you took it straight as-is with no merge conflicts. If so, that's a cherry-pick, not a backport.
The patch does not apply, there seems to have been a clang-format and/or style convention change. It was manually backported.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @svenevs)
Backport of pybind#3694
Relates: RobotLocomotion/drake#18262, RobotLocomotion/drake#18297
This change is