-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Update pybind11 to include [email protected] patches #18297
[workspace] Update pybind11 to include [email protected] patches #18297
Conversation
@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jwnimmer-tri for review please (part of the other two PRs).
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @jwnimmer-tri)
The CI testing choice looks correct. Once it passes, you can merge the pybind11 PR and then refresh the details here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok) +(release notes: none) pending sha fixup.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions (waiting on @svenevs)
tools/workspace/pybind11/repository.bzl
line 7 at r1 (raw file):
# Using the `drake` branch of this repository. _REPOSITORY = "svenevs/pybind11"
Suggestion:
RobotLocomotion
tools/workspace/pybind11/repository.bzl
line 13 at r1 (raw file):
# and if it has changed, then update the version number in the two # pybind11-*.cmake files in the current directory to match. _COMMIT = "3d90c7d32ea615148e7ec1ac609f773f5580f478"
Suggestion:
36695db542e1c34f6db7ca3ebb0415de30762395
d430cdf
to
7c64019
Compare
@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-snopt-mosek-release please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge once CI passes (one final sanity check, worth it).
Reviewable status: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)
tools/workspace/pybind11/repository.bzl
line 7 at r1 (raw file):
# Using the `drake` branch of this repository. _REPOSITORY = "svenevs/pybind11"
Done.
tools/workspace/pybind11/repository.bzl
line 13 at r1 (raw file):
# and if it has changed, then update the version number in the two # pybind11-*.cmake files in the current directory to match. _COMMIT = "3d90c7d32ea615148e7ec1ac609f773f5580f478"
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @svenevs)
Relates: RobotLocomotion/pybind11#60, #18262.
This change is