-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lcm-related bazel library names #8727
Update lcm-related bazel library names #8727
Conversation
825a798
to
ac1152d
Compare
+@sammy-tri for all review, please. |
One minor question + one really minor BTW. Reviewed 20 of 20 files at r1. lcm/BUILD.bazel, line 9 at r1 (raw file):
BTW the spelling of the path to tools/install/libdrake/build_components.bzl, line 110 at r1 (raw file):
BTW Now that Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. tools/install/libdrake/build_components.bzl, line 110 at r1 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
/me facepalm. It's autogenerated. Never mind. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. lcm/BUILD.bazel, line 9 at r1 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
OK Hmm, I see that's a project-wide problem now. I'll open an issue => #8732. tools/install/libdrake/build_components.bzl, line 110 at r1 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
OK Right! Also the work on #6464 actually makes it so all of the colon-library details here get eviscerated, very soon now. Comments from Reviewable |
Remove //util:lcm_util forwarding header, long since deprecated. Rename //lcm:lcm to //lcm:real to clarify that it is only a concrete implementation of the interface, instead of everything in the package. Do not rename in-tree uses to match; they can use the package-level library without adding overly many spurious dependencies. Rename //systems/lcm:lcm to //systems/lcm:lcm_pubsub to clarify that it is only the publisher and subscriber systems, instead of everything in the package. Rename all in-tree uses to match. Add drake_cc_package_library for //lcm and //systems/lcm.
ac1152d
to
622d593
Compare
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Remove
//util:lcm_util
forwarding header, long since deprecated.Rename
//lcm:lcm
to//lcm:real
to clarify that it is only a concrete implementation of the interface, instead of everything in the package. Do not rename in-tree uses to match; they can use the package-level library without adding overly many spurious dependencies.Rename
//systems/lcm:lcm
to//systems/lcm:lcm_pubsub
to clarify that it is only the publisher and subscriber systems, instead of everything in the package. Rename all in-tree uses to match.Add
drake_cc_package_library
for//lcm
and//systems/lcm
.Builds on #8664. Relates #6464.
This change is