-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
framework_py: Add test of using AbstractValue's in input ports, fix overload error for unique_ptr in pybind #8094
framework_py: Add test of using AbstractValue's in input ports, fix overload error for unique_ptr in pybind #8094
Conversation
9e808c3
to
c562357
Compare
Fixed the random errors in the pybind PR (due to recycled memory, instance registration stuff). +@jadecastro for feature review, please. Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
c562357
to
60803cd
Compare
Pybind PR has landed - updated in |
Pass complete. Reviewed 7 of 7 files at r1. bindings/pydrake/systems/framework_py.cc, line 283 at r1 (raw file):
BTW, comparing with the abstract binding, it no longer makes sense to me for this one to be a bindings/pydrake/systems/primitives_py.cc, line 36 at r1 (raw file):
BTW, could you also check/add a test for this (vector) version of the ctor? bindings/pydrake/systems/test/general_test.py, line 172 at r1 (raw file):
BTW, I don't think this needs to be cloned as a separate value. Comments from Reviewable |
(pending existing issues/cleanup) Reviewed 7 of 7 files at r1. Comments from Reviewable |
f5b2129
to
6c406cd
Compare
Review status: 2 of 7 files reviewed at latest revision, 3 unresolved discussions. bindings/pydrake/systems/framework_py.cc, line 283 at r1 (raw file): Previously, jadecastro (Jonathan DeCastro) wrote…
Done. Good catch - thanks! bindings/pydrake/systems/primitives_py.cc, line 36 at r1 (raw file): Previously, jadecastro (Jonathan DeCastro) wrote…
Done. bindings/pydrake/systems/test/general_test.py, line 172 at r1 (raw file): Previously, jadecastro (Jonathan DeCastro) wrote…
Done. Comments from Reviewable |
6c406cd
to
ea3a403
Compare
Reviewed 5 of 5 files at r2, 1 of 1 files at r3. Comments from Reviewable |
|
ea3a403
to
617b2ff
Compare
617b2ff
to
0bff5cf
Compare
Closes #8074
Address part of
AbstractValue
point in #7660. (Just need to follow-up with unrestricted updates.)When I was first prototyping accepting
unique_ptr
as arguments inpybind
, I introduced a bug where any registered pybind type would match with any other pybind type. This is fixed via RobotLocomotion/pybind11#10(I ultimately made this a possibility when supporting anti-slicing stuff for
shared_ptr
, but just hadn't incorporated it until now...)This also fixes a minor issue with
cpp_template
- any instantiations may have had the wrong module name used becauseinspect
was not called with the right frame count. That has now been fixed.This change is