-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FindLibraryTest by making it platform-dependent #7632
Fix FindLibraryTest by making it platform-dependent #7632
Conversation
@drake-jenkins-bot mac-sierra-clang-bazel-experimental-everything please |
+@fbudin69500 for feature-review, please. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Thanks for solving this issue. I'll double check that there is not a problem in the function that is tested, but this seems like a very simple fix that makes sense. The function Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
+@EricCousineau-TRI for platform-review, please. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file):
BTW It was a little hard for me to figure out at what point in the chain Could you either (a) manually create a test Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, EricCousineau-TRI wrote…
Sorry, promoting this to blocking rather than BTW. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, EricCousineau-TRI wrote…
Can that be a follow up so that we get the Mac builds blue again? Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Yup. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, EricCousineau-TRI (Eric Cousineau) wrote…
@fbudin69500 , could you open an issue to keep track of the items that @EricCousineau-TRI suggested? Comments from Reviewable |
common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, soonho-tri (Soonho Kong) wrote…
I'll go ahead and do this; it should take about 10min (fingers crossed). Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. common/test/find_loaded_library_test.cc, line 16 at r1 (raw file): Previously, EricCousineau-TRI wrote…
Thank you. FYI, just merged this PR into Comments from Reviewable |
The original code was added by #7439.
See https://drake-jenkins.csail.mit.edu/view/Continuous%20Production/job/mac-sierra-clang-bazel-continuous-release/271/consoleText.
This PR merely changes the test to make CI happy. @fbudin69500, please check if the original test failure indicates an issue in
LoadedLibraryPath
./cc @jamiesnape, @sammy-tri, @jwnimmer-tri (reviewers of #7439)
/cc @ggould-tri (buildcop)
This change is