-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQ for DualABI incompatibility with gcc-4.9. #7491
Add FAQ for DualABI incompatibility with gcc-4.9. #7491
Conversation
+@jamiesnape for feature review, please. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 1 of 1 files at r1. doc/faq.rst, line 120 at r1 (raw file):
BTW Change "correct compiler" to "supported compiler" and link to the supported platforms matrix? Also maybe you could add a note to below that matrix saying that the binary packages are built with Clang 4.0 on Ubuntu 16.04 and Apple Clang 9.0 on macOS 10.13 and then link somewhere in the last part of sentence there (if the binary packages are being used). Comments from Reviewable |
a41c23a
to
31a4eb3
Compare
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. doc/faq.rst, line 120 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. How does this look? Comments from Reviewable |
Reviewed 2 of 3 files at r2, 1 of 1 files at r3. doc/faq.rst, line 120 at r1 (raw file): Previously, EricCousineau-TRI wrote…
Good. Comments from Reviewable |
+@sammy-tri for platform review, please. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. doc/developers.rst, line 100 at r3 (raw file):
Per offline conversation change Clang 4.0 to GCC 5.4. Comments from Reviewable |
first pass (mostly) complete Reviewed 2 of 3 files at r2. doc/developers.rst, line 97 at r3 (raw file):
I feel like this section might be premature as there are no binary packages available at this time. doc/faq.rst, line 110 at r3 (raw file):
I can't figure out what options this text refers to. doc/faq.rst, line 120 at r3 (raw file):
I don't know where the reader would have gotten a pre-compiled binary. Comments from Reviewable |
31a4eb3
to
e0fcdff
Compare
Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions. doc/developers.rst, line 97 at r3 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
We have them (see below), but they are not linked into the documentation. @jamiesnape Should we include these links in the documentation? (So that way people don't have to dig in the issue? We can still say it's experimental at this point.) doc/developers.rst, line 100 at r3 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. doc/faq.rst, line 110 at r3 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
One of the three methods: Binary, Source, Docker. doc/faq.rst, line 120 at r3 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
These ones? Comments from Reviewable |
Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions. doc/developers.rst, line 97 at r3 (raw file): Previously, EricCousineau-TRI wrote…
Sure. Comments from Reviewable |
Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions. doc/developers.rst, line 100 at r3 (raw file): Previously, EricCousineau-TRI wrote…
Thanks. The jobs on Jenkins have been updated also. Comments from Reviewable |
Reviewed 1 of 1 files at r3, 1 of 1 files at r4. doc/faq.rst, line 110 at r3 (raw file): Previously, EricCousineau-TRI wrote…
I don't think any of those documents describes running the install step and then building a project which links to drake libraries which isn't built inside drake, but I could have missed it. Comments from Reviewable |
e0fcdff
to
7a46237
Compare
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions. doc/developers.rst, line 97 at r3 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. doc/faq.rst, line 110 at r3 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
Done. Added text regarding experimental CMake projects, linked to the Comments from Reviewable |
Reviewed 2 of 2 files at r5. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
+(status: curate commits before merging) Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
-(status: curate commits before merging) Sorry about that! I should have paid more attention to the contents of the individual commits. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
This addresses #7467 per the discussion.
\cc @jamiesnape @jwnimmer-tri @naveenoid
This change is