Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade pybind11 to latest commit #20524

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 11, 2023

Closes #20516.

See RobotLocomotion/pybind11#69.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added status: do not merge status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Nov 11, 2023
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer, labeled "do not merge" (waiting on @jwnimmer-tri)

a discussion (no related file):
Working: I'd like to have an automated test if possible to confirm this works as intended.

Will see if I can work 77c2e56 into this PR and confirm issue repro and the fix.


Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer, labeled "do not merge" (waiting on @jwnimmer-tri)

a discussion (no related file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Working: I'd like to have an automated test if possible to confirm this works as intended.

Will see if I can work 77c2e56 into this PR and confirm issue repro and the fix.

Ah, derp. I think we can't automate this, unless we have CI that actually has scipy proper.

Will confirm this patch fixes #20519


Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer, labeled "do not merge" (waiting on @jwnimmer-tri)

a discussion (no related file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Ah, derp. I think we can't automate this, unless we have CI that actually has scipy proper.

Will confirm this patch fixes #20519

Done.

With command:

bazel run //bindings/pydrake/solvers:py/mathematicalprogram_test -- TestMathematicalProgram.test_linear_constraints

Confirmed it fails at af945db (#20519 + some changes)
Confirmed it works in c1acc16 (with this commit + some changes)


Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: pending commit bump

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer, labeled "do not merge" (waiting on @jwnimmer-tri)


tools/workspace/pybind11/repository.bzl line 11 at r1 (raw file):

# and if it has changed, then update the version number in the two
# pybind11-*.cmake files in the current directory to match.
_COMMIT = "2831b214d93cb1b0f35b77644a3056078025d2a3"

Needs bump to pybind11@drake.

@jwnimmer-tri jwnimmer-tri force-pushed the workspace-pybind-upgrade branch from 1ec1d52 to 09e9b7b Compare November 11, 2023 20:54
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review November 11, 2023 20:55
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer (waiting on @jwnimmer-tri)


tools/workspace/pybind11/repository.bzl line 11 at r1 (raw file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Needs bump to pybind11@drake.

Done

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)

@EricCousineau-TRI EricCousineau-TRI merged commit aa0c645 into RobotLocomotion:master Nov 11, 2023
1 check passed
@jwnimmer-tri jwnimmer-tri deleted the workspace-pybind-upgrade branch November 27, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[py mp] MathematicalProgram.AddLinearConstraint prefers sparse overload?
2 participants