Deprecate all optitrack-related code for removal #19866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drake::systems::sensors::OptitrackLcmFrameSender - drake::systems::sensors::OptitrackReceiver - The @optitrack_driver external - The installed optitrack_client program Note that this does not add Bazel deprecation markers anywhere (doing so ends up being extra trouble for downstreams).
jwnimmer-tri
added
priority: medium
release notes: newly deprecated
|
+@rpoyner-tri for feature review, please. |
ggould-tri
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),ggould-tri(platform)
|
FYI See here for alternative packaging for users: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for alternative packaging for users:
https://github.com/RobotLocomotion/optitrack-driver/releases/tag/v0.0.20230714
The following code will be removed in ~3 months:
drake::systems::sensors::OptitrackLcmFrameSenderdrake::systems::sensors::OptitrackReceiver@optitrack_driverexternaloptitrack_clientprogramNote that this does not add Bazel deprecation markers anywhere (doing so ends up being extra trouble for downstreams).
Closes #19600.
This change is