Allow tests to pass with both fmt < 7.1 and fmt >= 7.1 #14379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default string formatting of integer-valued floating-point values changed as of fmt 7.1.0. In anticipation of Drake releases (or at least some Drake users) building against older revisions of fmt, we adjust the magic string literals in tests to allow for either spelling.
jwnimmer-tri
added
priority: low
status: single reviewer ok
sammy-tri
reviewed
Nov 20, 2020
There was a problem hiding this comment.
+@sammy-tri for review
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)
sammy-tri
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignee sammy-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default string formatting of integer-valued floating-point values changed as of fmt 7.1.0. In anticipation of Drake releases (or at least some Drake users) building against older revisions of fmt, we adjust magic string literals in tests to allow for either spelling.
Relates #14220. Amends #14272.
\CC @hidmic FYI
This change is