-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds coverage to two blocks of code in IntegratorBase. #12363
Adds coverage to two blocks of code in IntegratorBase. #12363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sherm1 for feature review please
Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers (waiting on @sherm1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed due to IntegratorBase linting.
Feature pending some clarifications.
+@sammy-tri for platform review per rotation, please
Reviewed 2 of 2 files at r1.
Reviewable status: 3 unresolved discussions, LGTM missing from assignee sammy-tri(platform) (waiting on @edrumwri and @sammy-tri)
systems/analysis/test/integrator_base_test.cc, line 82 at r1 (raw file):
// Two values for at_minimum_step_size. bool at_minimum_step_size_true = true; bool at_minimum_step_size_false = false;
minor: I'm confused about these names, especially when the code below expects at_minimum_step_size_true==false
. Please add some comments explaining these names and what they are supposed to do.
systems/analysis/test/integrator_base_test.cc, line 93 at r1 (raw file):
std::pair<bool, double> result; result = integrator.CalcAdjustedStepSize(zero_error, step_taken, &at_minimum_step_size_true);
Is this parameter in/out or just out?
systems/analysis/test/integrator_base_test.cc, line 125 at r1 (raw file):
// Reset the minimum step size Booleans. at_minimum_step_size_true = true; at_minimum_step_size_false = false;
minor: you just checked that they are set to these values above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: 3 unresolved discussions, LGTM missing from assignee sammy-tri(platform) (waiting on @edrumwri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @sammy-tri and @sherm1)
systems/analysis/test/integrator_base_test.cc, line 93 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
Is this parameter in/out or just out?
Documentation now points out that these are input and output parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @sherm1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
Resolves #12329
This change is