Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all example binaries in the Drake install #4224

Closed
david-german-tri opened this issue Nov 22, 2016 · 8 comments
Closed

Include all example binaries in the Drake install #4224

david-german-tri opened this issue Nov 22, 2016 · 8 comments
Labels
component: distribution Nightly binaries, monthly releases, docker, installation priority: backlog unused team: kitware

Comments

@david-german-tri
Copy link
Contributor

This matters, for instance, to KUKA users.

cc @patmarion
@jamiesnape
Copy link
Contributor

Also useful for #1766.

patmarion added a commit to patmarion/drake that referenced this issue Nov 22, 2016
@patmarion
update paths to kuka exes
93157dc 
after issue RobotLocomotion#4224 is resolved then I will update the paths once again.
@patmarion patmarion mentioned this issue Nov 22, 2016
Merged
@patmarion
Copy link
Member

I would still like to see this happen in the CMake build. But if there's no plans to do so, please close this issue.

@jwnimmer-tri
Copy link
Collaborator

I think the issue is still valid even some CMake listfiles are going away -- the Bazel binary release could / should include those artifacts.

@david-german-tri
Copy link
Contributor Author

I am going to bump the priority down to medium, though.

@jamiesnape jamiesnape mentioned this issue Sep 27, 2017
Merged
fbudin69500 pushed a commit to fbudin69500/drake that referenced this issue Nov 9, 2017
Install more examples: iiwa_wsg_simulation and kuka_simulation
5f88631 
Follow-up PR for RobotLocomotion#7120 which installed one of the kuka examples, but
not all (See issue RobotLocomotion#4224).
fbudin69500 pushed a commit to fbudin69500/drake that referenced this issue Nov 9, 2017
Install more examples: iiwa_wsg_simulation and kuka_simulation
26eda88 
Follow-up PR for RobotLocomotion#7120 which installed one of the kuka examples, but
not all (See issue RobotLocomotion#4224).
@fbudin69500 fbudin69500 mentioned this issue Nov 9, 2017
Merged
fbudin69500 pushed a commit to fbudin69500/drake that referenced this issue Nov 16, 2017
Install more examples: iiwa_wsg_simulation and kuka_simulation
71d83bf 
Follow-up PR for RobotLocomotion#7120 which installed one of the kuka examples, but
not all (See issue RobotLocomotion#4224). It also moves the installed examples from
`bin/` to `examples/<example_sub_directory>/`.
fbudin69500 pushed a commit to fbudin69500/drake that referenced this issue Nov 16, 2017
Install more examples: iiwa_wsg_simulation and kuka_simulation
1a29b07 
Follow-up PR for RobotLocomotion#7120 which installed one of the kuka examples, but
not all (See issue RobotLocomotion#4224). It also moves the installed examples from
`bin/` to `share/drake/examples/<example_sub_directory>/`.
@EricCousineau-TRI
Copy link
Contributor

Closing, given that Francois's PRs for a subset of examples have landed.

@jwnimmer-tri
Copy link
Collaborator

I thought the goal was to install ~all examples?

@jamiesnape
Copy link
Contributor

It is.

@jamiesnape jamiesnape reopened this Feb 8, 2018
@EricCousineau-TRI EricCousineau-TRI changed the title Include example binaries in the Drake install Include all example binaries in the Drake install Feb 8, 2018
@jwnimmer-tri jwnimmer-tri mentioned this issue Oct 10, 2018
Closed
3 tasks
@jwnimmer-tri jwnimmer-tri added the component: distribution Nightly binaries, monthly releases, docker, installation label Apr 28, 2020
@jwnimmer-tri
Copy link
Collaborator

We don't seem to be suffering for not having this since the past four years, and adding more C++ binaries would only increase the image footprint when most users just want the library, not the demos. Using online notebooks for the demos seems to be the way of the future.

Unless anyone speaks up about this in the next month or two, we'll plan to close this as "won't fix".

@jamiesnape jamiesnape mentioned this issue Sep 16, 2020
Closed
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
@jwnimmer-tri jwnimmer-tri mentioned this issue Nov 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: distribution Nightly binaries, monthly releases, docker, installation priority: backlog unused team: kitware
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@patmarion @jamiesnape @mwoehlke-kitware @david-german-tri @jwnimmer-tri @EricCousineau-TRI