Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Mac dependencies #312

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Sep 20, 2024

Towards #61


This change is Reviewable

@BetsyMcPhail BetsyMcPhail force-pushed the mac-dependencies branch 4 times, most recently from 933e83f to 4257359 Compare September 20, 2024 16:35
@BetsyMcPhail BetsyMcPhail changed the title Remove duplicate Mac dependencies Remove unnecessary Mac dependencies Sep 20, 2024
These may be outdated or already installed by the drake binary
install_prereqs script.
Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri and +@nicolecheetham for review please

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee nicolecheetham, platform LGTM missing (waiting on @jwnimmer-tri and @nicolecheetham)

Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee nicolecheetham, platform LGTM from [jwnimmer-tri] (waiting on @nicolecheetham)

Copy link
Collaborator

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [jwnimmer-tri] (waiting on @BetsyMcPhail)

@jwnimmer-tri jwnimmer-tri merged commit 4a886fa into RobotLocomotion:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants