Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GHA build tests #299

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Refactor GHA build tests #299

merged 1 commit into from
Sep 16, 2024

Conversation

nicolecheetham
Copy link
Collaborator

@nicolecheetham nicolecheetham commented Sep 12, 2024 •
edited by jwnimmer-tri
Loading

Cleans up github actions' build tests so they are more clear and concise

Issue: #61

This change is Reviewable

nicolecheetham
nicolecheetham commented Sep 12, 2024
View reviewed changes
Copy link
Collaborator Author

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@BetsyMcPhail for feature review

Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)

BetsyMcPhail
BetsyMcPhail approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @nicolecheetham)

nicolecheetham
nicolecheetham commented Sep 16, 2024
View reviewed changes
Copy link
Collaborator Author

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for platform review

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM from [betsymcphail] (waiting on @jwnimmer-tri)

jwnimmer-tri
jwnimmer-tri approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail, jwnimmer-tri] (waiting on @nicolecheetham)

@jwnimmer-tri jwnimmer-tri merged commit 556e579 into RobotLocomotion:main Sep 16, 2024
6 checks passed
@nicolecheetham nicolecheetham deleted the gha_build_refactor branch September 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnimmer-tri jwnimmer-tri jwnimmer-tri approved these changes

@BetsyMcPhail BetsyMcPhail BetsyMcPhail approved these changes

Assignees

@BetsyMcPhail BetsyMcPhail

@jwnimmer-tri jwnimmer-tri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolecheetham @BetsyMcPhail @jwnimmer-tri