Update github macos setup for drake prereqs #297
Conversation
nicolecheetham
force-pushed
the
dde_macsonoma_refactor
branch
from
417b0a2
to
1350761
Compare
There was a problem hiding this comment.
+@BetsyMcPhail for feature review
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @nicolecheetham)
There was a problem hiding this comment.
+@xuchenhan-tri for platform review
Reviewable status: all discussions resolved, LGTM missing from assignee xuchenhan-tri, platform LGTM from [betsymcphail] (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee xuchenhan-tri, platform LGTM from [betsymcphail] (waiting on @nicolecheetham)
scripts/setup/mac/install_prereqs line 7 at r2 (raw file):
# Installs a /usr/local/bin/bazel symlink that conflicts with that installed by # the bazel formula in Homebrew.
BTW, the comment here seems to be incompatible with the code below. Am I just not getting it?
Code quote:
# Installs a /usr/local/bin/bazel symlink that conflicts with that installed by
# the bazel formula in Homebrew.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail, xuchenhan-tri] (waiting on @nicolecheetham)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail, xuchenhan-tri] (waiting on @BetsyMcPhail and @xuchenhan-tri)
scripts/setup/mac/install_prereqs line 7 at r2 (raw file):
Previously, xuchenhan-tri wrote…
BTW, the comment here seems to be incompatible with the code below. Am I just not getting it?
You are correct. The comment is supposed to start with "Uninstalls" as to properly describe the code below. I have updated so this is the case.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
nicolecheetham
force-pushed
the
dde_macsonoma_refactor
branch
from
3cadcb8
to
063de9d
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Simplifying DEE approach of installing drake prereqs for macOS
Issue: #61
This change is