Make examples folders self-contained by including necessary setup files #225
Conversation
alesgenova
added
status: not ready to merge
and removed
status: not ready to merge
labels
There was a problem hiding this comment.
Reviewed 45 of 45 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @alesgenova)
.github/workflows/ci.yml, line 93 at r1 (raw file):
run: ./scripts/continuous_integration/github_actions/ubuntu_apt/build_test shell: bash verify_setup_files:
This test shows as passing when it was run on this PR but it is actually failing with git: command not found
scripts/setup/utils/update_setup_files.sh, line 1 at r1 (raw file):
#!/bin/bash
Would it make sense to have a few lines of documentation on how/when to use this file?
alesgenova
force-pushed
the
self-contained-examples
branch
from
0e07970
to
8d508ab
Compare
alesgenova
force-pushed
the
self-contained-examples
branch
from
8d508ab
to
eab5606
Compare
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @BetsyMcPhail)
.github/workflows/ci.yml, line 93 at r1 (raw file):
Previously, BetsyMcPhail (Betsy McPhail) wrote…
This test shows as passing when it was run on this PR but it is actually failing with
git: command not found
I made changes to ensure that the action will actually fail if an error occurs (and also fixed the error that was happening)
scripts/setup/utils/update_setup_files.sh, line 1 at r1 (raw file):
Previously, BetsyMcPhail (Betsy McPhail) wrote…
Would it make sense to have a few lines of documentation on how/when to use this file?
Added a short explanation of what the script does
There was a problem hiding this comment.
Verified that the test ran successfully.
+@jwnimmer-tri for review please
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
BetsyMcPhail
assigned BetsyMcPhail and jwnimmer-tri and unassigned jwnimmer-tri and BetsyMcPhail
alesgenova
force-pushed
the
self-contained-examples
branch
2 times, most recently
from
079aec8
to
ddedaec
Compare
|
Is this PR fully finished? My recollection from the last Kitware/TRI sync meeting was that it was known to be incomplete and is still being reworked. Let me know whether I should start my review. |
|
Hearing nothing, I'll de-assign myself in order to clean up my reviews dashboard. Feel free to re-add me once it's ready. |
alesgenova
force-pushed
the
self-contained-examples
branch
from
ddedaec
to
466be10
Compare
alesgenova
force-pushed
the
self-contained-examples
branch
from
466be10
to
6d88ba7
Compare
|
Thank you for your contribution. This pull request has been open for 180 days without activity and so is considered stale. It will be automatically closed in 14 days unless you comment or remove the "result: stale" label. |
|
Thank you for your contribution. This pull request has been open for 180 days without activity and so is considered stale. It will be automatically closed in 14 days unless you comment or remove the "result: stale" label. |
Working towards #61
This change is