Remove support for Ubuntu 18 (Bionic) #222

BetsyMcPhail · 2022-03-11T01:36:14Z

Resolves #219

This change is

BetsyMcPhail · 2022-03-11T01:36:41Z

Jenkins PR build: https://drake-jenkins.csail.mit.edu/job/RobotLocomotion/job/drake-external-examples/view/change-requests/job/PR-222/

BetsyMcPhail · 2022-03-11T02:13:34Z

Not surprisingly, there are 3 failures:

FAIL: //apps:simple_logging_example_test (see /media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/execroot/drake_external_examples/bazel-out/k8-opt/testlogs/apps/simple_logging_example_test/test.log)
INFO: From Testing //apps:simple_logging_example_test:
==================== Test output for //apps:simple_logging_example_test:
Traceback (most recent call last):
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/1/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/simple_logging_example_test.runfiles/drake_external_examples/apps/simple_logging_example.py", line 38, in <module>
    from pydrake.systems.analysis import Simulator
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/1/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/simple_logging_example_test.runfiles/drake/.lib/python3.6/site-packages/pydrake/systems/__init__.py", line 2, in <module>
    import pydrake.common as _common
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/1/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/simple_logging_example_test.runfiles/drake/.lib/python3.6/site-packages/pydrake/common/__init__.py", line 8, in <module>
    from ._module_py import *
ModuleNotFoundError: No module named 'pydrake.common._module_py'
================================================================================
FAIL: //apps:import_all_test (see /media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/execroot/drake_external_examples/bazel-out/k8-opt/testlogs/apps/import_all_test/test.log)
INFO: From Testing //apps:import_all_test:
==================== Test output for //apps:import_all_test:
Traceback (most recent call last):
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/3/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/import_all_test.runfiles/drake_external_examples/apps/import_all_test.py", line 34, in <module>
    import pydrake.all
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/3/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/import_all_test.runfiles/drake/.lib/python3.6/site-packages/pydrake/all.py", line 31, in <module>
    from .autodiffutils import *
ModuleNotFoundError: No module named 'pydrake.autodiffutils'
================================================================================
FAIL: //apps:find_resource_test (see /media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/execroot/drake_external_examples/bazel-out/k8-opt/testlogs/apps/find_resource_test/test.log)
INFO: From Testing //apps:find_resource_test:
==================== Test output for //apps:find_resource_test:
Traceback (most recent call last):
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/2/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/find_resource_test.runfiles/drake_external_examples/apps/find_resource_test.py", line 35, in <module>
    from pydrake.common import FindResourceOrThrow, set_log_level
  File "/media/ephemeral0/ubuntu/workspace/n_drake-external-examples_PR-222/_bazel_ubuntu/6515737b8af406b380abfa5945a3c7db/sandbox/linux-sandbox/2/execroot/drake_external_examples/bazel-out/k8-opt/bin/apps/find_resource_test.runfiles/drake/.lib/python3.6/site-packages/pydrake/common/__init__.py", line 8, in <module>
    from ._module_py import *
ModuleNotFoundError: No module named 'pydrake.common._module_py'

BetsyMcPhail

Issue #214 gave a good hint to the failures. drake_bazel_installed uses the bionic nightly packages by default, and therefore, in the tests.

Reviewable status: all discussions resolved, platform LGTM missing

Also remove references to Bionic-specific Ros 2 Dashing and Ros Melodic.

BetsyMcPhail

+@jwnimmer-tri for review please. This PR goes further than described in the issue and removes all support for Bionic. The final commit can be split off and saved until April if you prefer.

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)

jwnimmer-tri · 2022-03-11T17:45:29Z

I think a total purge of Bionic is correct. I'll review the non-ROS parts of this.

+@EricCousineau-TRI for review of the ament- and catkin-related changes, please.

jwnimmer-tri

on my parts.

Reviewed 14 of 20 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee ericcousineau-tri, platform LGTM from [jwnimmer-tri] (waiting on @BetsyMcPhail, @EricCousineau-TRI, and @jwnimmer-tri)

a discussion (no related file):
nit The top-level README.md in this repo says "Not all example projects are supported on macOS or Ubuntu 20.04 (Focal Fossa)." which probably inaccurate now?

All examples are supported on Focal.

BetsyMcPhail

Reviewable status: 1 unresolved discussion, LGTM missing from assignee ericcousineau-tri, platform LGTM from [jwnimmer-tri] (waiting on @EricCousineau-TRI and @jwnimmer-tri)

a discussion (no related file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

nit The top-level README.md in this repo says "Not all example projects are supported on macOS or Ubuntu 20.04 (Focal Fossa)." which probably inaccurate now?

Good catch. I'm not sure if was actually ever true. It certainly shouldn't be now.

jwnimmer-tri

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee ericcousineau-tri, platform LGTM from [jwnimmer-tri] (waiting on @EricCousineau-TRI and @jwnimmer-tri)

EricCousineau-TRI

Reviewed 19 of 20 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee ericcousineau-tri, platform LGTM from [jwnimmer-tri] (waiting on @BetsyMcPhail)

.github/workflows/ci.yml, line 55 at r2 (raw file):

        shell: zsh -efuo pipefail {0}
  ros_foxy:
    name: ros 2 foxy

BTW Latest support is for Galactic:
https://docs.ros.org/en/galactic/Installation.html
FYI @IanTheEngineer Once we have ROS 2 / Anzu integration underway, we should add that here.

EricCousineau-TRI

for ament- and catkin-related changes - thanks!

Reviewable status: complete! all discussions resolved, platform LGTM from [jwnimmer-tri, ericcousineau-tri] (waiting on @BetsyMcPhail)

BetsyMcPhail force-pushed the jenkins-focal branch from 8b41fc9 to b7d7027 Compare March 11, 2022 16:32

BetsyMcPhail added 2 commits March 11, 2022 11:52

CI: Switch Jenkins jobs from Bionic to Focal

b868f95

Switch drake_bazel_install from Bionic to Focal

69eda3b

BetsyMcPhail force-pushed the jenkins-focal branch from b7d7027 to 69eda3b Compare March 11, 2022 16:54

BetsyMcPhail commented Mar 11, 2022

View reviewed changes

BetsyMcPhail changed the title ~~CI: Switch Jenkins jobs from Bionic to Focal~~ Remove support for Ubuntu 18 (Bionic) Mar 11, 2022

BetsyMcPhail added 2 commits March 11, 2022 12:32

Remove Bionic and Ros Dashing Github Actions

1f0499e

Remove support for Bionic

8d7706b

Also remove references to Bionic-specific Ros 2 Dashing and Ros Melodic.

BetsyMcPhail force-pushed the jenkins-focal branch from 27327a2 to 8d7706b Compare March 11, 2022 17:33

BetsyMcPhail assigned jwnimmer-tri Mar 11, 2022

BetsyMcPhail commented Mar 11, 2022

View reviewed changes

jwnimmer-tri assigned EricCousineau-TRI Mar 11, 2022

jwnimmer-tri approved these changes Mar 11, 2022

View reviewed changes

Update README

68eda08

All examples are supported on Focal.

BetsyMcPhail commented Mar 11, 2022

View reviewed changes

jwnimmer-tri reviewed Mar 11, 2022

View reviewed changes

EricCousineau-TRI approved these changes Mar 11, 2022

View reviewed changes

BetsyMcPhail merged commit 0aea162 into RobotLocomotion:main Mar 11, 2022

BetsyMcPhail deleted the jenkins-focal branch March 11, 2022 20:22

BetsyMcPhail mentioned this pull request Apr 11, 2022

Dropping Ubuntu 18.04 (Bionic) CI RobotLocomotion/drake#16842

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for Ubuntu 18 (Bionic) #222

Remove support for Ubuntu 18 (Bionic) #222

BetsyMcPhail commented Mar 11, 2022 •

edited

Loading

BetsyMcPhail commented Mar 11, 2022

BetsyMcPhail commented Mar 11, 2022

BetsyMcPhail left a comment

BetsyMcPhail left a comment

jwnimmer-tri commented Mar 11, 2022

jwnimmer-tri left a comment

BetsyMcPhail left a comment

jwnimmer-tri left a comment

EricCousineau-TRI left a comment

EricCousineau-TRI left a comment

Remove support for Ubuntu 18 (Bionic) #222

Remove support for Ubuntu 18 (Bionic) #222

Conversation

BetsyMcPhail commented Mar 11, 2022 • edited Loading

BetsyMcPhail commented Mar 11, 2022

BetsyMcPhail commented Mar 11, 2022

BetsyMcPhail left a comment

Choose a reason for hiding this comment

BetsyMcPhail left a comment

Choose a reason for hiding this comment

jwnimmer-tri commented Mar 11, 2022

jwnimmer-tri left a comment

Choose a reason for hiding this comment

BetsyMcPhail left a comment

Choose a reason for hiding this comment

jwnimmer-tri left a comment

Choose a reason for hiding this comment

EricCousineau-TRI left a comment

Choose a reason for hiding this comment

EricCousineau-TRI left a comment

Choose a reason for hiding this comment

BetsyMcPhail commented Mar 11, 2022 •

edited

Loading