Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drake_bazel_installed] Highlight OS_CODENAME with a named variable #215

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Jan 19, 2022

Otherwise, users will overlook the hard-coded URL buried below (#214 (comment)).


This change is Reviewable

Otherwise, users will overlook the hard-coded URL buried below.
@jwnimmer-tri
Copy link
Contributor Author

+@BetsyMcPhail for review, please.

@BetsyMcPhail
Copy link
Contributor

Good catch! I don't seem to have a Reviewable button? LGTM

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable should be fixed now.

:lgtm: rubber stamp to convince it.

Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM from [jwnimmer-tri] (waiting on @BetsyMcPhail)

@jwnimmer-tri jwnimmer-tri merged commit f5e4dd1 into RobotLocomotion:main Feb 15, 2022
@jwnimmer-tri jwnimmer-tri deleted the os_codename branch February 15, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants