-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start moving packaging to CMake builds #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://drake-jenkins.csail.mit.edu/view/Packaging/job/linux-jammy-unprovisioned-gcc-bazel-experimental-packaging/24/
https://drake-jenkins.csail.mit.edu/view/Packaging/job/mac-arm-ventura-unprovisioned-clang-bazel-experimental-packaging/10/
Reviewable status: 0 of 8 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mwoehlke-kitware)
driver/configurations/bazel.cmake
line 44 at r1 (raw file):
# Set bazel options set(DASHBOARD_BAZEL_STARTUP_OPTIONS) set(DASHBOARD_OUTPUT_USER_ROOT "${CTEST_BINARY_DIRECTORY}")
DASHBOARD_OUTPUT_USER_ROOT
is still used in tools/user.bazelrc.in.
Add ability for CMake builds to perform packaging steps. A major motivation for this, besides that CMake builds are the only officially supported mechanism for installs (which means we ought to have been using CMake for packages all along), is that this allows us to use the VERSION.TXT generated by the Drake build, rather than having our own logic to create it. For now, Bazel packaging is left alone so that we can make sure the new jobs are working, but the intent is to remove them in the near future.
8be6778
to
f25b618
Compare
Previously, BetsyMcPhail (Betsy McPhail) wrote…
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mwoehlke-kitware)
Add ability for CMake builds to perform packaging steps. A major motivation for this, besides that CMake builds are the only officially supported mechanism for installs (which means we ought to have been using CMake for packages all along), is that this allows us to use the VERSION.TXT generated by the Drake build, rather than having our own logic to create it.
For now, Bazel packaging is left alone so that we can make sure the new jobs are working, but the intent is to remove them in the near future.
Requires RobotLocomotion/drake#21146.
This change is