Add ROS service/client widget #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add example of widget working with turtlesim Spawn service definition. [Ticket: X]
wolfv
reviewed
Apr 5, 2022
jupyros/ros_widgets.py
Outdated
| def call_srv(arg): | ||
| msg_to_send = srv_type._request_class() | ||
| widget_dict_to_msg(msg_to_send, widget_dict) | ||
| rospy.wait_for_service(srv_name) |
There was a problem hiding this comment.
we could move the wait_for_service call outside the callback, and we could also give a timeout (it's an optional parameter).
What do you think?
There was a problem hiding this comment.
Is it necessary to wait for the service? We could also simply check if the service is there and throw an error if it's not, would that be better?
wolfv
reviewed
Apr 5, 2022
|
Looks great to me! |
Clean up ROS Service notebook and move wait_for_service function outside the callback. [Ticket: 92]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function generates a widget similar to the publisher/subscriber widget.