Prepare repository for ROS2 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wolfv
I refactored the repo to separate ROS1 from ROS2 in two different sub-packages. By default jupyros still export everything from ros1, and at the moment, ros2 re-exports everything from ros1.
I'm not sure if we should create the ros1 folder. My idea is to prevent ROS2 users to import something that doesn't work on ROS2 by mistake.
With this organization, we can still import ROS1 as a default using:
import jupyrosorfrom jupyros import ros3dAnd at the same time have a separate package for ROS2:
from jupyros import ros2orfrom jupyros.ros2 import ros3d