Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String casting improvements #361

Merged
merged 9 commits into from
Sep 8, 2017
Merged

String casting improvements #361

merged 9 commits into from
Sep 8, 2017

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Sep 8, 2017

Ocramius
Ocramius reviewed Sep 8, 2017
View reviewed changes
stub/Exception.stub
protected $code;
protected $file;
protected $line;
private $trace;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice findings :P

Ocramius
Ocramius reviewed Sep 8, 2017
View reviewed changes
test/unit/Fixture/StringCastParameters.php
iterable $iterable,
object $object
)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS went a bit bananas here, but not really important.

Ocramius
Ocramius approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks incredibly good!

I like that all these __toString() are now split out: easier to drop them later on.

Kids: don't use __toString() information ;-)

@Ocramius Ocramius self-assigned this Sep 8, 2017
@Ocramius Ocramius added this to the 2.0.0 milestone Sep 8, 2017
@Ocramius Ocramius merged commit 4be7704 into Roave:master Sep 8, 2017
@Ocramius Ocramius mentioned this pull request Sep 8, 2017
Closed
@Ocramius
Copy link
Member

Ocramius commented Sep 8, 2017

Thanks @kukulich!

@Ocramius Ocramius mentioned this pull request Sep 8, 2017
Closed
@kukulich kukulich deleted the export branch September 8, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius