ReflectionClass::export incompatibilities

[asgrim]

1) /home/travis/build/Roave/BetterReflection/test/compat/ReflectionClass_export_basic1.phpt
Failed asserting that format description matches text.
--- Expected
+++ Actual
@@ @@
 Class [ <user> class C extends A ] {
-  @@ %s 14-14
+  @@  3-7
@@ @@
   - Methods [2] {
-    Method [ <user, inherits A> public method privf ] {
-      @@ %s 3 - 3
-
+    Method [ <user> public method privf ] {
+      @@  6 - 8
+    
       - Parameters [1] {
         Parameter #0 [ <required> Exception $a ]
       }
     }
-
-    Method [ <user, inherits A> public method pubf ] {
-      @@ %s 4 - 11
-
+    Method [ <user> public method pubf ] {
+      @@  10 - 12
+    
       - Parameters [8] {
         Parameter #0 [ <required> A $a ]
         Parameter #1 [ <required> $b ]
         Parameter #2 [ <optional> C or NULL $c = NULL ]
-        Parameter #3 [ <optional> $d = '16 chars long -...' ]
+        Parameter #3 [ <optional> $d = '16 chars long --' ]
         Parameter #4 [ <optional> $e = '15 chars long -' ]
         Parameter #5 [ <optional> $f = NULL ]
         Parameter #6 [ <optional> $g = false ]
-        Parameter #7 [ <optional> array or NULL $h = NULL ]
+        Parameter #7 [ <optional> array $h = NULL ]
       }
     }
   }
 }
2) /home/travis/build/Roave/BetterReflection/test/compat/ReflectionClass_export_basic2.phpt
Failed asserting that format description matches text.
--- Expected
+++ Actual
@@ @@
 Class [ <user> class c ] {
-  @@ %s 2-5
+  @@  3-11
@@ @@
 }
-
 Class [ <user> class d extends c ] {
-  @@ %s 7-7
+  @@  3-7

   - Constants [0] {
   }

   - Static properties [0] {
   }

   - Static methods [0] {
   }

   - Properties [0] {
   }

   - Methods [0] {
   }
 }

[asgrim]

Issues identified:

ReflectionClass_export_basic1.phpt

• inherits definition is missing
• string truncation is missing 16 chars long -...
• array or NULL $h = NULL (correct) vs array $h = NULL (ours)

ReflectionClass_export_basic2.phpt

• phpt running issue related to missing filename (see ReflectionClass->getFileName() fails when run in a .phpt sebastianbergmann/phpunit#1783 which blocks this)
• line numbers are different both classes c and d

[Ocramius]

Mostly handled in #361. Need to check whether anything still needs work here

[kukulich]

I think this can be closed. I've probably already implemented everything mentioned in #144 (comment). And export() methods were removed.

[Ocramius]

Will mark it as done: ::export() is completely gone 👍