IsDateTime should return true when using Moment (see NjsonSchema) #1613 #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for PR #3660.
When using Moment, the TimeSpan class is not converted to the correct format when it is part of the url parameters.
Nswag doesn't append the .format('d.hh:mm:ss.SS', { trim: false }) method on TimeSpans, while in NjsonSchema, this is done correctly. This causes TimeSpans to be converted to Moments differently when used in the url parameter or in the body.
The source of this issue lies in the fact that in NjsonSchema, the IsDateTime function returns true when a TimeSpan is used (NJsonSchema.CodeGeneration.TypeScript/DataConversionGenerator.cs).
In Nswag this was not yet the case, so this was added in this PR.
Kind regards,
Bjarne