Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for date and datetimes from the body to the request url #1613 #3660

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Add logic for date and datetimes from the body to the request url #1613 #3660

merged 1 commit into from
Nov 11, 2021

Conversation

bjarne-callewaert
Copy link
Contributor

@bjarne-callewaert bjarne-callewaert commented Oct 13, 2021

This PR resolves an issue where the dates and dateTimes in the request url are not formatted to the correct string value (e.g. when OffsetMomentJS is chosen in the settings, the offset was lost due to the .toJSON()) (#1613)

This logic was copied from NJS, where this was already implemented for dateTimes that live inside the body of a request

@RicoSuter RicoSuter merged commit 34eeb97 into RicoSuter:master Nov 11, 2021
@RicoSuter
Copy link
Owner

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants