Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature stroke color #84

Closed
wants to merge 2 commits into from
Closed

Feature stroke color #84

wants to merge 2 commits into from

Conversation

aliemre
Copy link

@aliemre aliemre commented Sep 26, 2017

It provide stroke color as props in JS definition. Also it is only possible on Android currently. Reference to #81
Here's an example:

<SignatureCapture 
    style={{flex: 1}} 
    ref="sign" 
    onSaveEvent={this._onSaveEvent} 
    onDragEvent={this._onDragEvent} 
    saveImageFileInExtStorage={false} 
    showNativeButtons={false} 
    showTitleLabel={false} 
    viewMode={"portrait"} 
    strokeColor="#3BC7C1" />

@aliemre aliemre changed the title Feature stroke color #81 Feature stroke color Sep 26, 2017
@aliemre aliemre mentioned this pull request Sep 26, 2017
@dgladkov
Copy link

dgladkov commented Sep 28, 2017

Just wanted to note that our company has a fork that supports custom stroke and background colors on both Android and iOS, along with the option to switch off the border: https://github.com/GlossGenius/react-native-signature-capture

If you are interested to move these features upstream, I can try to make a PR for this.

@aliemre
Copy link
Author

aliemre commented Sep 28, 2017

@dgladkov That would be good actually. However, I think this project is no longer maintained. Don't waste your time. Other PR's are still pending. I follow your repository now.

@jedt
Copy link
Contributor

jedt commented Jan 21, 2021

Closing as duplicate of #216

@jedt jedt closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants