Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stroke+background colors to be set on iOS+Android #216

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

amyboyd
Copy link
Contributor

@amyboyd amyboyd commented Jun 17, 2020

  • Allow backgroundColor to be customized on iOS.
  • Allow backgroundColor to be transparent in Android.
  • Allow strokeColor to be changed on iOS.
  • Remove line breaks from Android's base 64 encoding.

@jedt
Copy link
Contributor

jedt commented Jan 21, 2021

Hi @amyboyd thanks, we want to merge this. Do you have the time to update the Example project and add the new parameters on the readme?

@jedt jedt added needs example update Project example needs to be updated with the change needs readme update The Readme must be updated with the change labels Jan 21, 2021
This was referenced Jan 21, 2021
@jedt jedt merged commit ff37346 into RepairShopr:master Jan 26, 2021
@jedt jedt removed needs example update Project example needs to be updated with the change needs readme update The Readme must be updated with the change labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants