Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test related to the fix #625 #664

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SRC/slarrv.f
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ SUBROUTINE SLARRV( N, VL, VU, D, L, PIVMIN,
*
* Quick return if possible
*
IF( (N.LE.0).OR.(M.LE.0) ) THEN
IF( N.LE.0 ) THEN
RETURN
END IF
*
Expand Down
51 changes: 50 additions & 1 deletion TESTING/EIG/schkee.F
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@ PROGRAM SCHKEE
$ SDRGEV, SDRGSX, SDRGVX, SDRVBD, SDRVES, SDRVEV,
$ SDRVSG, SDRVST, SDRVSX, SDRVVX, SERRBD,
$ SERRED, SERRGG, SERRHS, SERRST, ILAVER, XLAENV,
$ SDRGES3, SDRGEV3,
$ SDRGES3, SDRGEV3, SLARRV, SCOPY,
$ SCHKST2STG, SDRVST2STG, SCHKSB2STG, SDRVSG2STG
* ..
* .. Intrinsic Functions ..
Expand Down Expand Up @@ -1884,6 +1884,52 @@ PROGRAM SCHKEE
CALL OMP_SET_NUM_THREADS(N_THREADS)
#endif
END IF
*
* Test if SLARRV returns INFO=0 and do not modify the output when
* (N.LE.0).OR.(M.LE.0)
*
* These tests are related to the fix:
* https://github.com/Reference-LAPACK/lapack/pull/625
*
* Test M = 0 on SLARRV:
*
WRITE( NOUT, FMT = 9958 )'M'
CALL SCOPY( 8, A, 1, WORK, 1 )
IWORK(1) = 100
CALL SLARRV( 1, 1.0E0, 1.0E0, A(1,1), A(2,1),
$ 1.0E0, IWORK(2), 0,
$ 1, 0, 1.0E0, 1.0E0, 1.0E0,
$ A(3,1), A(4,1), A(5,1), IWORK(2),
$ IWORK(2), A(6,1), A(8,1), 5,
$ IWORK(2), A(9,1), IWORK(2), INFO )
IF( INFO.NE.0 ) THEN
WRITE( NOUT, FMT = 9959 )INFO, 'M'
ELSE
DO K = 1, 8
IF( A(K,1) .NE. WORK(K) ) THEN
WRITE( NOUT, FMT = 9958 )'M'
END IF
END DO
END IF
*
* Test N = 0 on SLARRV:
*
CALL SCOPY( 1, A, 1, WORK, 1 )
IWORK(1) = 100
CALL SLARRV( 0, 1.0E0, 1.0E0, A, A,
$ 1.0E0, IWORK(2), 1,
$ 1, 0, 1.0E0, 1.0E0, 1.0E0,
$ A, A, A, IWORK(2),
$ IWORK(2), A, A(1,1), 5,
$ IWORK(2), A(2,1), IWORK(2), INFO )
IF( INFO.NE.0 ) THEN
WRITE( NOUT, FMT = 9959 )INFO, 'N'
ELSE
IF( A(1,1) .NE. WORK(1) ) THEN
WRITE( NOUT, FMT = 9958 )'N'
END IF
END IF
*
DO 290 I = 1, NPARMS
CALL XLAENV( 1, NBVAL( I ) )
CALL XLAENV( 2, NBMIN( I ) )
Expand Down Expand Up @@ -2534,6 +2580,9 @@ PROGRAM SCHKEE
$ ', INWIN =', I4, ', INIBL =', I4, ', ISHFTS =', I4,
$ ', IACC22 =', I4)
9960 FORMAT( / ' Tests of the CS Decomposition routines' )
9959 FORMAT( ' SLARRV returned INFO ', I4, ' WHEN ', A, ' = 0' )
9958 FORMAT( ' SLARRV returned INFO 0 but modified the input WHEN '
$ , A, ' = 0' )
*
* End of SCHKEE
*
Expand Down