Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test related to the fix #625 #664

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weslleyspereira
Copy link
Collaborator

This PR adds a test related to the fix #625.

The test:

  • Verifies if xLARRV returns INFO=0 when (N.EQ.0).OR.(M.EQ.0).
  • Verifies if xLARRV modifies its outputs when (N.EQ.0).OR.(M.EQ.0).

The problem related on #625 was the out-of-bounds access IBLOCK( 0 ). To try to stress this problem does not happen anymore, I set IWORK(1) = 100 and use the array IWORK(2) as IBLOCK.

  • For now, the test was implemented only SLARRV. If the test makes sense, implement it on DLARRV, CLARRV and ZLARRV.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (6195fab) compared to base (def1271).
Patch has no changes to coverable lines.

❗ Current head 6195fab differs from pull request most recent head 351f5ac. Consider uploading reports for the commit 351f5ac to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1894     1894           
  Lines      184054   184054           
=======================================
  Misses     184054   184054           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@weslleyspereira weslleyspereira force-pushed the try-test-fix-from-625 branch 2 times, most recently from 02bdea9 to 9593a14 Compare April 27, 2022 21:43
DO K = 1, 8
IF( A(K,1) .NE. WORK(K) ) THEN
WRITE( NOUT, FMT = 9958 )'M'
EXIT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this EXIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant