Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace node-fetch with native fetch #1763

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Oct 11, 2024

What/Why/How?

Checking another approach to get rid off punycode message.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: a5320b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 979.5 ± 15.0 964.0 1006.7 1.00 ± 0.02
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 976.0 ± 18.8 944.4 1005.9 1.00

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.55% 4991/6354
🟡 Branches 67.17% 2066/3076
🟡 Functions 72.98% 824/1129
🟡 Lines 78.84% 4709/5973
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 core/src/env.d.ts 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / registry-api.ts
50% (-1.35% 🔻)
33.33% 50%
48.57% (-1.43% 🔻)
🟢
... / fetch-with-timeout.ts
92.31%
62.5% (-37.5% 🔻)
50% 92.31%
🟡
... / push.ts
73.37% 70% 54.55% 75.78%

Test suite run success

809 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from a5320b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant