-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update dependencies to remove punycode depricated package #1755
base: main
Are you sure you want to change the base?
Chore: update dependencies to remove punycode depricated package #1755
Conversation
🦋 Changeset detectedLatest commit: 1f397dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success809 tests passing in 121 suites. Report generated by 🧪jest coverage report action from 1f397dc |
packages/core/src/utils.ts
Outdated
}, | ||
ProxyAgent: (new (arg0: string) => any) | null; | ||
|
||
if (typeof window === 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is has to be fixed very carefully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its for browser support, I found some logger tests for that.
Going to test in vscode / monorepo with some verdaccio package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to isBrowser
from .env
. Or should we use some other workaround?
It is more strict but similar:
export const isBrowser =
typeof window !== 'undefined' ||
typeof process === 'undefined' ||
(process?.platform as any) === 'browser'; // main and worker thread
export const env = isBrowser ? {} : process.env || {};
@@ -1,555 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tatomyr
This package-lock looks obsolete in the mono-repo setup, but please tell me if there is some idea behind it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try removing it and see what happens.
Going to test another approach with native fetch => #1763 |
What/Why/How?
In order to eliminate
punycode
deprecated warning we need to switch fromnode-fetch
package that has it as a transitive dependency.It was decided to move to
undici
as it has full functionality and supports proxyAgent out of the box, comparing to nativefetch
(available from node version 18).But it comes at a price - this is going to be breaking change as requires to rise minimal nodeJS version to
Reference
Closes: #1332
Testing
Screenshots (optional)
Check yourself
Security