-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncAPI linting support #1127
AsyncAPI linting support #1127
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success635 tests passing in 93 suites. Report generated by 🧪jest coverage report action from 577890e |
|
🦋 Changeset detectedLatest commit: 577890e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tatomyr I think this is ready for your review. I see the build is failing, but I'm not sure if I should be pushing prettier fixes to files I didn't change ... @TaylorKrusen if you want to have a look at the guide I wrote, it would be good to get some feedback on that. |
@lornajane no worries, we'll figure out what's wrong with the prettier later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lornajane I updated the tests and renamed the majorSpecVersion
function into getMajorSpecVersion
. Also left a few more questions and suggestions.
P.S. Please rebase this against the main branch and add a changeset.
Co-authored-by: Andrew Tatomyr <[email protected]>
c8f2966
to
efa2d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the MR, but as it now contains my changes too, I'd like someone else from the team to approve it as well. 🙂
Co-authored-by: Andrew Tatomyr <[email protected]>
What/Why/How?
(description edited by @lornajane as the idea takes shape!)
The goal is to add linting support for AsyncAPI files to Redocly. Initially this will be partial AsyncAPI v2.6.0 support, and feedback is very welcome.
Progress:
Examples of AsyncAPI files can be found in the AsyncAPI project: https://github.com/asyncapi/spec/tree/master/examples
Reference
Fixes #1126
Testing
Screenshots (optional)
Check yourself
Security