Add support for TS.MGET with options. minor refactor and go fmt. #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 81.09% 81.66% +0.56%
==========================================
Files 6 7 +1
Lines 455 469 +14
==========================================
+ Hits 369 383 +14
Misses 46 46
Partials 40 40
Continue to review full report at Codecov.
|
|
cc @stevesim101 |
|
|
||
| .PHONY: all test coverage | ||
| all: test coverage | ||
|
|
||
| checkfmt: |
There was a problem hiding this comment.
@filipecosta90 While this will work, an easier way of linting in go would be using https://github.com/golangci/golangci-lint
There was a problem hiding this comment.
@danni-m I've used this go fmt approach as a quick fix/quick enforcing of fmt. Will revise the required changes to use golangci-lint and move towards that afterwards. wdyt of adding this quick check to be safeguarded and with more time moving to something more correct/sophisticated?
There was a problem hiding this comment.
@filipecosta90 sounds good to me, just want to make sure you are aware that this tool exists.
|
@filipecosta90 Im think its pretty good, I would reconsider having 2 functions. |
@danni-m I believe that for being backwards compatible we need them both. Notwithstanding followed your advise and merge the internals of both. wdyt? |
This PR adresses #64 .
It also enforces
go fmtto pass the PR.