Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for MultiGetWithOptions #64

Closed
stevesim101 opened this issue Jul 17, 2020 · 5 comments
Closed

Request for MultiGetWithOptions #64

stevesim101 opened this issue Jul 17, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@stevesim101
Copy link

Please add the ability to run a TS.MGET with options (i.e., optional args) to this package. We need to run TS.MGET with the arg WITHLABELS.

Example:
TS.MGET WITHLABELS filter type=foo id=1

@filipecosta90 filipecosta90 self-assigned this Jul 17, 2020
@filipecosta90 filipecosta90 added the enhancement New feature or request label Jul 17, 2020
@filipecosta90
Copy link
Collaborator

hi there @stevesim101 we will gladly do so :) Thank you for the feedback 👍

@filipecosta90
Copy link
Collaborator

hi there @stevesim101 #67 has been merged and you should be able to try it with the current master :)
We should release shortly a new version.

@stevesim101
Copy link
Author

Thank you @filipecosta90 for the quick turnaround!

@stevesim101
Copy link
Author

@filipecosta90 - Yes, please create a new release. The current 1.2.1 release is missing this and other commits from May 8 and May 11. We use vendoring in our go projects for external packages. So running go mod vendor only pulls from your latest release.

@filipecosta90
Copy link
Collaborator

@filipecosta90 - Yes, please create a new release. The current 1.2.1 release is missing this and other commits from May 8 and May 11. We use vendoring in our go projects for external packages. So running go mod vendor only pulls from your latest release.

hi there @stevesim101 , we've just released 1.3.0 with the requested feature included :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants