fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider #1800

karelhala · 2023-03-21T09:37:29Z

Description

ROS team brought to our attention that their tab is always hidden on inventory detail. This happend because of recent inventory refactoring and we forgot to move certain part of the code. This PR re-enables it and also removes unused part of redux code which was used in the past to calculate the visibility.

Regression

#1435

karelhala · 2023-03-21T11:21:28Z

restarting jenkins

PreetiW · 2023-03-21T12:26:58Z

src/routes/InventoryDetail.js

+    const cloudProvider = useSelector(({ systemProfileStore }) => systemProfileStore?.systemProfile?.cloud_provider);
+    const availableApps = useMemo(() => appList.map((app) => app.name === 'ros' ? {
+        ...app,
+        isVisible: ['aws', 'azure'].includes(cloudProvider)


@karelhala ATM ros is only supported for aws, can you please update this accordingly!

PreetiW

minor nitpick, rest looks good to me!

mkholjuraev

Just a minor suggestion.

mkholjuraev · 2023-03-21T14:25:46Z

src/routes/InventoryDetail.js

@@ -75,6 +75,11 @@ const Inventory = () => {
    const writePermissions = useWritePermissions();
    const entityLoaded = useSelector(({ entityDetails }) => entityDetails?.loaded);
    const entity = useSelector(({ entityDetails }) => entityDetails?.entity);
+    const cloudProvider = useSelector(({ systemProfileStore }) => systemProfileStore?.systemProfile?.cloud_provider);
+    const availableApps = useMemo(() => appList.map((app) => app.name === 'ros' ? {


I believe if this was moved to InventoryDetail component under the routes folder, it would make cleaner code. Because, this component is used by other apps and do not deal with this case I think.

karelhala · 2023-03-27T07:16:42Z

@mkholjuraev the file should be in right place. Anything else to adjust? Thank you.

codecov-commenter · 2023-03-27T07:28:12Z

Codecov Report

Patch coverage has no change and project coverage change: -0.43 ⚠️

Comparison is base (192de1c) 65.87% compared to head (86efd50) 65.45%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
- Coverage   65.87%   65.45%   -0.43%     
==========================================
  Files         129      129              
  Lines        3156     3155       -1     
  Branches      992      992              
==========================================
- Hits         2079     2065      -14     
- Misses       1077     1090      +13

Impacted Files	Coverage Δ
src/routes/InventoryDetail.js	`0.00% <0.00%> (ø)`
src/store/reducers.js	`70.00% <ø> (+5.18%)`	⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mkholjuraev · 2023-03-27T08:33:12Z

@karelhala thank you for letting me know. Nope, all seems good!

…atInsights#1800) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

## [1.12.3](v1.12.2...v1.12.3) (2023-03-28) ### Bug Fixes * **RHCLOUD-24793:** Show ROS tab is azure or aws cloud provider ([#1800](#1800)) ([2331f03](2331f03))

gkarat · 2023-03-28T08:01:17Z

🎉 This PR is included in version 1.12.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

… (#1811) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

… (#1810) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

… (#1812) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

* feat(ESSNTL-4056): Add lastSeen filter (#1781) * feat(ESSNTL-4056): Add lastSeen filter * fix test * feat(ESSNTL-4056): move functionality inside the filter component * Add min date * chore(release): 1.8.0 [skip ci] # [1.8.0](v1.7.2...v1.8.0) (2023-03-07) ### Features * **ESSNTL-4056:** Add lastSeen filter ([#1781](#1781)) ([7bb6ac8](7bb6ac8)) * feat(ESSNTL-3737, -3735): Rename and delete group (#1780) Implements https://issues.redhat.com/browse/ESSNTL-3737. Implements https://issues.redhat.com/browse/ESSNTL-3735. This makes it possible to rename or delete a group from the group details page. * chore: Comment InventoryGroupDetail loading test (#1789) Temporarily removes the "loading test" due to some problems it causes for the next tests. * chore(release): 1.9.0 [skip ci] # [1.9.0](v1.8.0...v1.9.0) (2023-03-13) ### Features * **ESSNTL-3737, -3735:** Rename and delete group ([#1780](#1780)) ([bdf4c6a](bdf4c6a)) * test: Bring intercept responses to one format (#1782) This rewrites some interceptors to always have the third argument compliant with the interceptors' response object interface (e.g., always include statusCode, body). Co-authored-by: Aleksandr Voznesenskii <[email protected]> * chore(release): 1.9.1 [skip ci] ## [1.9.1](v1.9.0...v1.9.1) (2023-03-13) * fix(ESSNTL-4404): global filters and tags (#1788) Before, if you applied a global filter (workloads, sids, tags), the inventory table did not reflect the filter. Now global filters are applied to the table and work together with table filters. Co-authored-by: Michael Johnson <[email protected]> * chore(release): 1.9.2 [skip ci] ## [1.9.2](v1.9.1...v1.9.2) (2023-03-13) ### Bug Fixes * **ESSNTL-4404:** global filters and tags ([#1788](#1788)) ([b10ce31](b10ce31)) * feat(ESSNTL-3727): Display group systems (#1790) * Connect group details with inventory table * Remove sorting from the system update method col * Enhance tableProps, implement select none/page * Implement tests for GroupSystems.cy.js * Remove hostIds from fixtures to avoid render table * chore(release): 1.10.0 [skip ci] # [1.10.0](v1.9.2...v1.10.0) (2023-03-14) ### Features * **ESSNTL-3727:** Display group systems ([#1790](#1790)) ([08408ad](08408ad)) * chore: Mock GET groups related requests (#1793) This serves as a temporary solution for the missing GET endpoints implementation on the API level. This will allow QEs to open the views and find required components selectors. * fix(ESSNTL-3760): handle insights disconnected hosts for patch, advisor, vuln tabs (#1791) Co-authored-by: Aleksandr Voznesenskii <[email protected]> * chore(release): 1.10.1 [skip ci] ## [1.10.1](v1.10.0...v1.10.1) (2023-03-14) ### Bug Fixes * **ESSNTL-3760:** handle insights disconnected hosts for patch, advisor, vuln tabs ([#1791](#1791)) ([f8d7afd](f8d7afd)) * feat(ESSNTL-4196): Show group detail info tab (#1792) Implements https://issues.redhat.com/browse/ESSNTL-4196. * chore(release): 1.11.0 [skip ci] # [1.11.0](v1.10.1...v1.11.0) (2023-03-15) ### Features * **ESSNTL-4196:** Show group detail info tab ([#1792](#1792)) ([f0f421b](f0f421b)) * feat(ESSNTL-4195): Inventory table - group filter (#1776) Implements https://issues.redhat.com/browse/ESSNTL-4195. * chore(release): 1.12.0 [skip ci] # [1.12.0](v1.11.0...v1.12.0) (2023-03-15) ### Features * **ESSNTL-4195:** Inventory table - group filter ([#1776](#1776)) ([358400e](358400e)) * chore(RHIF-180): Supress data in sentry/hotjar (#1784) * chore: CI new job trigger * ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787) * fix(ESSNTL-4056): updates for edge cases * Add additional edge cases * fix: Fix the CI error related to lastSeen filter (#1802) This adds a fallback value for lastSeenFilter object which appears to be undefined or null in some CI tests. * chore(release): 1.12.1 [skip ci] ## [1.12.1](v1.12.0...v1.12.1) (2023-03-22) ### Bug Fixes * Fix the CI error related to lastSeen filter ([#1802](#1802)) ([a19f6aa](a19f6aa)) * refactor(RHIF-125): Apply useChrome everywhere (#1801) Implements https://issues.redhat.com/browse/RHIF-125. This replaces the remaining occurrences of direct call to insights.chrome with useChrome hook. * chore(release): 1.12.2 [skip ci] ## [1.12.2](v1.12.1...v1.12.2) (2023-03-22) * chore: Stop calling deprecated chrome.init (#1803) Relates to https://issues.redhat.com/browse/RHIF-125. * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider (#1800) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS * chore(release): 1.12.3 [skip ci] ## [1.12.3](v1.12.2...v1.12.3) (2023-03-28) ### Bug Fixes * **RHCLOUD-24793:** Show ROS tab is azure or aws cloud provider ([#1800](#1800)) ([2331f03](2331f03)) * chore(deps): update frontend-components to 3.9.33 * chore: Don't use extra span tag to render tab text (#1797) * chore: Refactor .travis.yml CI configuration (#1806) * chore: Build before executing deploy script in CI * docs: Updated props for inventory table [skip ci] (#1816) * feat(ESSNTL-3729): Add new actions to kebab and new modal (#1794) Implements https://issues.redhat.com/browse/ESSNTL-3729, https://issues.redhat.com/browse/ESSNTL-3730. --------- Co-authored-by: Georgy Karataev <[email protected]> * chore(release): 1.13.0 [skip ci] # [1.13.0](v1.12.3...v1.13.0) (2023-03-29) ### Features * **ESSNTL-3729:** Add new actions to kebab and new modal ([#1794](#1794)) ([011f64c](011f64c)) * feat(ESSNTL-3728): Enable multiple hosts addition to group (#1798) Implements https://issues.redhat.com/browse/ESSNTL-3728. * test: Fix failing AddSystemsToGroupModal test (#1818) * chore(release): 1.14.0 [skip ci] # [1.14.0](v1.13.0...v1.14.0) (2023-03-30) ### Features * **ESSNTL-3728:** Enable multiple hosts addition to group ([#1798](#1798)) ([c9a1d4e](c9a1d4e)) * fix(ESSNTL-4196): Tie URLs to chrome isBeta (#1817) Fixes https://issues.redhat.com/browse/ESSNTL-4196. * chore(release): 1.14.1 [skip ci] ## [1.14.1](v1.14.0...v1.14.1) (2023-03-30) ### Bug Fixes * **ESSNTL-4196:** Tie URLs to chrome isBeta ([#1817](#1817)) ([7c686e5](7c686e5)) * fix(ESSNTL-3727): Fix minor issues for groups/%id view (#1820) Fixes https://issues.redhat.com/browse/ESSNTL-3727. * chore(release): 1.14.2 [skip ci] ## [1.14.2](v1.14.1...v1.14.2) (2023-03-31) ### Bug Fixes * **ESSNTL-3727:** Fix minor issues for groups/%id view ([#1820](#1820)) ([1fa8d01](1fa8d01)) * fix(ESSNTL-3727): Hide Group filter (#1823) Hides the Group filter on the group systems view (/groups/%id). * chore(release): 1.14.3 [skip ci] ## [1.14.3](v1.14.2...v1.14.3) (2023-04-03) ### Bug Fixes * **ESSNTL-3727:** Hide Group filter ([#1823](#1823)) ([7657a7e](7657a7e)) * fix(ESSNTL-3728): Fix links, show missing tags filter (#1824) Fixes https://issues.redhat.com/browse/ESSNTL-3728. * Remove prepareColumns duplicate, use correct links * Show Tags filter in the filters dropdown * Fix AddSystemsToGroupModal tests * chore(release): 1.14.4 [skip ci] ## [1.14.4](v1.14.3...v1.14.4) (2023-04-03) ### Bug Fixes * **ESSNTL-3728:** Fix links, show missing tags filter ([#1824](#1824)) ([ebfad9c](ebfad9c)) * fix(RHIF-232): flickering inventory table is fixed, api reqs are reduced to 1 * chore: add ignoreRefresh prop to fix inventoryTable flickering * fix(RHIF-232): flickering inventory table is fixed, api reqs are reduced to 1 * chore(release): 1.14.5 [skip ci] ## [1.14.5](v1.14.4...v1.14.5) (2023-04-03) ### Bug Fixes * **RHIF-232:** flickering inventory table is fixed, api reqs are reduced to 1 ([97af8a3](97af8a3)) * fix(ESSNTL-3729): Fix add button behavior (#1825) Fixes https://issues.redhat.com/browse/ESSNTL-3729, https://issues.redhat.com/browse/ESSNTL-3730. --------- Co-authored-by: Georgy Karataev <[email protected]> * chore(release): 1.14.6 [skip ci] ## [1.14.6](v1.14.5...v1.14.6) (2023-04-06) ### Bug Fixes * **ESSNTL-3729:** Fix add button behavior ([#1825](#1825)) ([cdf9848](cdf9848)) * fix(inventory groups): changed the column order to allign with the app (#1828) * bug(inventory groups): changed the column order to allign with the app * fix(inventory groups): fixed tests * chore(release): 1.14.7 [skip ci] ## [1.14.7](v1.14.6...v1.14.7) (2023-04-11) ### Bug Fixes * **inventory groups:** changed the column order to allign with the app ([#1828](#1828)) ([3124e53](3124e53)) * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" This reverts commit 8809e40. * chore(release): 1.14.8 [skip ci] ## [1.14.8](v1.14.7...v1.14.8) (2023-04-13) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787) * bug(inventory groups): fixing columns order in modal (#1829) * feat(inventory groups): fixed edge case with create group * fix(inventory groups): fixed edge case with cross button * bug(inventory groups): fixed order of columns in add system modal * fix(LastSeenFilter): Add edge cases for new filter * chore(release): 1.14.8 [skip ci] ## [1.14.8](v1.14.7...v1.14.8) (2023-04-14) ### Bug Fixes * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787) --------- Co-authored-by: Adonis Puente <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Georgy Karataev <[email protected]> Co-authored-by: Michael Johnson <[email protected]> Co-authored-by: Michael Johnson <[email protected]> Co-authored-by: Muslimjon <[email protected]> Co-authored-by: Georgii Karataev <[email protected]> Co-authored-by: Karel Hala <[email protected]> Co-authored-by: Alexandr Čelakovský <[email protected]> Co-authored-by: Travis CI User <[email protected]> Co-authored-by: Adonis Puente <[email protected]>

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider

31a886e

karelhala requested a review from a team as a code owner March 21, 2023 09:37

karelhala closed this Mar 21, 2023

karelhala reopened this Mar 21, 2023

PreetiW reviewed Mar 21, 2023

View reviewed changes

Enable ros only for AWS

4e9191a

mkholjuraev approved these changes Mar 21, 2023

View reviewed changes

Merge branch 'master' into enable-ros

86efd50

karelhala merged commit 2331f03 into RedHatInsights:master Mar 28, 2023

gkarat pushed a commit that referenced this pull request Mar 28, 2023

chore(release): 1.12.3 [skip ci]

09df6a7

## [1.12.3](v1.12.2...v1.12.3) (2023-03-28) ### Bug Fixes * **RHCLOUD-24793:** Show ROS tab is azure or aws cloud provider ([#1800](#1800)) ([2331f03](2331f03))

gkarat added the released label Mar 28, 2023

mkholjuraev pushed a commit that referenced this pull request Mar 28, 2023

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider (#1800)…

dd65458

… (#1811) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

mkholjuraev pushed a commit that referenced this pull request Mar 29, 2023

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider (#1800)…

0d0632c

… (#1810) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

mkholjuraev pushed a commit that referenced this pull request Mar 29, 2023

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider (#1800)…

b1cd309

… (#1812) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider #1800

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider #1800

karelhala commented Mar 21, 2023

karelhala commented Mar 21, 2023

PreetiW Mar 21, 2023

PreetiW left a comment

mkholjuraev left a comment

mkholjuraev Mar 21, 2023

karelhala commented Mar 27, 2023

codecov-commenter commented Mar 27, 2023

mkholjuraev commented Mar 27, 2023

gkarat commented Mar 28, 2023

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider #1800

fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider #1800

Conversation

karelhala commented Mar 21, 2023

Description

Regression

karelhala commented Mar 21, 2023

PreetiW Mar 21, 2023

Choose a reason for hiding this comment

PreetiW left a comment

Choose a reason for hiding this comment

mkholjuraev left a comment

Choose a reason for hiding this comment

mkholjuraev Mar 21, 2023

Choose a reason for hiding this comment

karelhala commented Mar 27, 2023

codecov-commenter commented Mar 27, 2023

Codecov Report

mkholjuraev commented Mar 27, 2023

gkarat commented Mar 28, 2023