feat(ESSNTL-4195): Inv table group filter #1776

Fewwy · 2023-02-28T14:47:42Z

This pr adds group filter to the inventory table that is hidden behind feature flag

https://issues.redhat.com/browse/ESSNTL-4195

…ilter

…cies

…ilter

Fewwy · 2023-03-13T11:06:04Z

/retest

Fewwy · 2023-03-13T12:55:28Z

/retest

codecov-commenter · 2023-03-13T15:02:06Z

Codecov Report

Patch coverage: 32.26% and project coverage change: -2.05 ⚠️

Comparison is base (b10ce31) 68.22% compared to head (5f51b37) 66.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
- Coverage   68.22%   66.18%   -2.05%     
==========================================
  Files         125      129       +4     
  Lines        2861     3111     +250     
  Branches      944      976      +32     
==========================================
+ Hits         1952     2059     +107     
- Misses        909     1052     +143

Impacted Files	Coverage Δ
src/components/GroupSystems/GroupSystems.cy.js	`0.00% <0.00%> (ø)`
src/components/GroupsTable/GroupsTable.cy.js	`0.00% <ø> (ø)`
...c/components/InventoryDetail/ApplicationDetails.js	`0.00% <0.00%> (ø)`
src/components/InventoryDetail/InventoryDetail.js	`0.00% <ø> (ø)`
...ponents/InventoryGroupDetail/GroupDetailInfo.cy.js	`0.00% <0.00%> (ø)`
src/components/InventoryTable/hooks/useColumns.js	`100.00% <ø> (ø)`
src/components/filters/index.js	`100.00% <ø> (ø)`
src/constants.js	`81.25% <0.00%> (-1.29%)`	⬇️
src/routes/InventoryTable.js	`59.32% <0.00%> (-7.92%)`	⬇️
src/store/entities.js	`53.57% <ø> (+20.23%)`	⬆️
... and 10 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gkarat

overall, LGTM, but needs a bit of more improvement. also, found out I cannot deselect the group from the toolbar, video:

Screencast.from.03-14-2023.11.01.14.AM.webm

gkarat · 2023-03-14T10:06:13Z

src/components/filters/useGroupFilter.test.js

+            await waitFor(() => {
+                expect(mockSystemProfile.history.get.length).toBe(1);
+            });


Can we also assert that this only request was to /groups URL? So that we feel more confident with this test: it checks that there is one request done and it was targeting /groups URL

src/components/filters/useGroupFilter.js

gkarat · 2023-03-14T10:12:56Z

src/components/filters/useGroupFilter.test.js

+            const { result } = renderHook(useGroupFilter, { wrapper });
+            expect(result.current).toMatchSnapshot();


This results in empty snapshots (equal to your third test where you check the empty state with no groups fetched). This is suspicious, can you take a look?

src/components/filters/useGroupFilter.js

gkarat · 2023-03-14T10:15:54Z

Just a note: it seems that after applying the group filter, the network request doesn't contain group_name parameter. It's gonna be added to spec here https://github.com/RedHatInsights/insights-host-inventory/pull/1285/files#diff-6b7977bd0eb33f42b9b33e2725d80da5d6618c59f96da50254d3fe660703c594R131-R133. Given that it's not implemented, let's omit it in this phase (this PR). I will create a separate Jira that will make sure we append this parameter in the requests.

…ilter

Fewwy · 2023-03-14T15:20:55Z

/retest

…ilter

gkarat

looks legit 👍🏼 approving

# [1.12.0](v1.11.0...v1.12.0) (2023-03-15) ### Features * **ESSNTL-4195:** Inventory table - group filter ([#1776](#1776)) ([358400e](358400e))

gkarat · 2023-03-15T13:19:29Z

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* feat(ESSNTL-4056): Add lastSeen filter (#1781) * feat(ESSNTL-4056): Add lastSeen filter * fix test * feat(ESSNTL-4056): move functionality inside the filter component * Add min date * chore(release): 1.8.0 [skip ci] # [1.8.0](v1.7.2...v1.8.0) (2023-03-07) ### Features * **ESSNTL-4056:** Add lastSeen filter ([#1781](#1781)) ([7bb6ac8](7bb6ac8)) * feat(ESSNTL-3737, -3735): Rename and delete group (#1780) Implements https://issues.redhat.com/browse/ESSNTL-3737. Implements https://issues.redhat.com/browse/ESSNTL-3735. This makes it possible to rename or delete a group from the group details page. * chore: Comment InventoryGroupDetail loading test (#1789) Temporarily removes the "loading test" due to some problems it causes for the next tests. * chore(release): 1.9.0 [skip ci] # [1.9.0](v1.8.0...v1.9.0) (2023-03-13) ### Features * **ESSNTL-3737, -3735:** Rename and delete group ([#1780](#1780)) ([bdf4c6a](bdf4c6a)) * test: Bring intercept responses to one format (#1782) This rewrites some interceptors to always have the third argument compliant with the interceptors' response object interface (e.g., always include statusCode, body). Co-authored-by: Aleksandr Voznesenskii <[email protected]> * chore(release): 1.9.1 [skip ci] ## [1.9.1](v1.9.0...v1.9.1) (2023-03-13) * fix(ESSNTL-4404): global filters and tags (#1788) Before, if you applied a global filter (workloads, sids, tags), the inventory table did not reflect the filter. Now global filters are applied to the table and work together with table filters. Co-authored-by: Michael Johnson <[email protected]> * chore(release): 1.9.2 [skip ci] ## [1.9.2](v1.9.1...v1.9.2) (2023-03-13) ### Bug Fixes * **ESSNTL-4404:** global filters and tags ([#1788](#1788)) ([b10ce31](b10ce31)) * feat(ESSNTL-3727): Display group systems (#1790) * Connect group details with inventory table * Remove sorting from the system update method col * Enhance tableProps, implement select none/page * Implement tests for GroupSystems.cy.js * Remove hostIds from fixtures to avoid render table * chore(release): 1.10.0 [skip ci] # [1.10.0](v1.9.2...v1.10.0) (2023-03-14) ### Features * **ESSNTL-3727:** Display group systems ([#1790](#1790)) ([08408ad](08408ad)) * chore: Mock GET groups related requests (#1793) This serves as a temporary solution for the missing GET endpoints implementation on the API level. This will allow QEs to open the views and find required components selectors. * fix(ESSNTL-3760): handle insights disconnected hosts for patch, advisor, vuln tabs (#1791) Co-authored-by: Aleksandr Voznesenskii <[email protected]> * chore(release): 1.10.1 [skip ci] ## [1.10.1](v1.10.0...v1.10.1) (2023-03-14) ### Bug Fixes * **ESSNTL-3760:** handle insights disconnected hosts for patch, advisor, vuln tabs ([#1791](#1791)) ([f8d7afd](f8d7afd)) * feat(ESSNTL-4196): Show group detail info tab (#1792) Implements https://issues.redhat.com/browse/ESSNTL-4196. * chore(release): 1.11.0 [skip ci] # [1.11.0](v1.10.1...v1.11.0) (2023-03-15) ### Features * **ESSNTL-4196:** Show group detail info tab ([#1792](#1792)) ([f0f421b](f0f421b)) * feat(ESSNTL-4195): Inventory table - group filter (#1776) Implements https://issues.redhat.com/browse/ESSNTL-4195. * chore(release): 1.12.0 [skip ci] # [1.12.0](v1.11.0...v1.12.0) (2023-03-15) ### Features * **ESSNTL-4195:** Inventory table - group filter ([#1776](#1776)) ([358400e](358400e)) * chore(RHIF-180): Supress data in sentry/hotjar (#1784) * chore: CI new job trigger * ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787) * fix(ESSNTL-4056): updates for edge cases * Add additional edge cases * fix: Fix the CI error related to lastSeen filter (#1802) This adds a fallback value for lastSeenFilter object which appears to be undefined or null in some CI tests. * chore(release): 1.12.1 [skip ci] ## [1.12.1](v1.12.0...v1.12.1) (2023-03-22) ### Bug Fixes * Fix the CI error related to lastSeen filter ([#1802](#1802)) ([a19f6aa](a19f6aa)) * refactor(RHIF-125): Apply useChrome everywhere (#1801) Implements https://issues.redhat.com/browse/RHIF-125. This replaces the remaining occurrences of direct call to insights.chrome with useChrome hook. * chore(release): 1.12.2 [skip ci] ## [1.12.2](v1.12.1...v1.12.2) (2023-03-22) * chore: Stop calling deprecated chrome.init (#1803) Relates to https://issues.redhat.com/browse/RHIF-125. * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider (#1800) * fix(RHCLOUD-24793): Show ROS tab is azure or aws cloud provider * Enable ros only for AWS * chore(release): 1.12.3 [skip ci] ## [1.12.3](v1.12.2...v1.12.3) (2023-03-28) ### Bug Fixes * **RHCLOUD-24793:** Show ROS tab is azure or aws cloud provider ([#1800](#1800)) ([2331f03](2331f03)) * chore(deps): update frontend-components to 3.9.33 * chore: Don't use extra span tag to render tab text (#1797) * chore: Refactor .travis.yml CI configuration (#1806) * chore: Build before executing deploy script in CI * docs: Updated props for inventory table [skip ci] (#1816) * feat(ESSNTL-3729): Add new actions to kebab and new modal (#1794) Implements https://issues.redhat.com/browse/ESSNTL-3729, https://issues.redhat.com/browse/ESSNTL-3730. --------- Co-authored-by: Georgy Karataev <[email protected]> * chore(release): 1.13.0 [skip ci] # [1.13.0](v1.12.3...v1.13.0) (2023-03-29) ### Features * **ESSNTL-3729:** Add new actions to kebab and new modal ([#1794](#1794)) ([011f64c](011f64c)) * feat(ESSNTL-3728): Enable multiple hosts addition to group (#1798) Implements https://issues.redhat.com/browse/ESSNTL-3728. * test: Fix failing AddSystemsToGroupModal test (#1818) * chore(release): 1.14.0 [skip ci] # [1.14.0](v1.13.0...v1.14.0) (2023-03-30) ### Features * **ESSNTL-3728:** Enable multiple hosts addition to group ([#1798](#1798)) ([c9a1d4e](c9a1d4e)) * fix(ESSNTL-4196): Tie URLs to chrome isBeta (#1817) Fixes https://issues.redhat.com/browse/ESSNTL-4196. * chore(release): 1.14.1 [skip ci] ## [1.14.1](v1.14.0...v1.14.1) (2023-03-30) ### Bug Fixes * **ESSNTL-4196:** Tie URLs to chrome isBeta ([#1817](#1817)) ([7c686e5](7c686e5)) * fix(ESSNTL-3727): Fix minor issues for groups/%id view (#1820) Fixes https://issues.redhat.com/browse/ESSNTL-3727. * chore(release): 1.14.2 [skip ci] ## [1.14.2](v1.14.1...v1.14.2) (2023-03-31) ### Bug Fixes * **ESSNTL-3727:** Fix minor issues for groups/%id view ([#1820](#1820)) ([1fa8d01](1fa8d01)) * fix(ESSNTL-3727): Hide Group filter (#1823) Hides the Group filter on the group systems view (/groups/%id). * chore(release): 1.14.3 [skip ci] ## [1.14.3](v1.14.2...v1.14.3) (2023-04-03) ### Bug Fixes * **ESSNTL-3727:** Hide Group filter ([#1823](#1823)) ([7657a7e](7657a7e)) * fix(ESSNTL-3728): Fix links, show missing tags filter (#1824) Fixes https://issues.redhat.com/browse/ESSNTL-3728. * Remove prepareColumns duplicate, use correct links * Show Tags filter in the filters dropdown * Fix AddSystemsToGroupModal tests * chore(release): 1.14.4 [skip ci] ## [1.14.4](v1.14.3...v1.14.4) (2023-04-03) ### Bug Fixes * **ESSNTL-3728:** Fix links, show missing tags filter ([#1824](#1824)) ([ebfad9c](ebfad9c)) * fix(RHIF-232): flickering inventory table is fixed, api reqs are reduced to 1 * chore: add ignoreRefresh prop to fix inventoryTable flickering * fix(RHIF-232): flickering inventory table is fixed, api reqs are reduced to 1 * chore(release): 1.14.5 [skip ci] ## [1.14.5](v1.14.4...v1.14.5) (2023-04-03) ### Bug Fixes * **RHIF-232:** flickering inventory table is fixed, api reqs are reduced to 1 ([97af8a3](97af8a3)) * fix(ESSNTL-3729): Fix add button behavior (#1825) Fixes https://issues.redhat.com/browse/ESSNTL-3729, https://issues.redhat.com/browse/ESSNTL-3730. --------- Co-authored-by: Georgy Karataev <[email protected]> * chore(release): 1.14.6 [skip ci] ## [1.14.6](v1.14.5...v1.14.6) (2023-04-06) ### Bug Fixes * **ESSNTL-3729:** Fix add button behavior ([#1825](#1825)) ([cdf9848](cdf9848)) * fix(inventory groups): changed the column order to allign with the app (#1828) * bug(inventory groups): changed the column order to allign with the app * fix(inventory groups): fixed tests * chore(release): 1.14.7 [skip ci] ## [1.14.7](v1.14.6...v1.14.7) (2023-04-11) ### Bug Fixes * **inventory groups:** changed the column order to allign with the app ([#1828](#1828)) ([3124e53](3124e53)) * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" This reverts commit 8809e40. * chore(release): 1.14.8 [skip ci] ## [1.14.8](v1.14.7...v1.14.8) (2023-04-13) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787) * bug(inventory groups): fixing columns order in modal (#1829) * feat(inventory groups): fixed edge case with create group * fix(inventory groups): fixed edge case with cross button * bug(inventory groups): fixed order of columns in add system modal * fix(LastSeenFilter): Add edge cases for new filter * chore(release): 1.14.8 [skip ci] ## [1.14.8](v1.14.7...v1.14.8) (2023-04-14) ### Bug Fixes * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787) --------- Co-authored-by: Adonis Puente <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Georgy Karataev <[email protected]> Co-authored-by: Michael Johnson <[email protected]> Co-authored-by: Michael Johnson <[email protected]> Co-authored-by: Muslimjon <[email protected]> Co-authored-by: Georgii Karataev <[email protected]> Co-authored-by: Karel Hala <[email protected]> Co-authored-by: Alexandr Čelakovský <[email protected]> Co-authored-by: Travis CI User <[email protected]> Co-authored-by: Adonis Puente <[email protected]>

Fewwy added 2 commits February 22, 2023 15:44

feat(invntory groups): added new group column behind feature flag

edd63e2

feat(inventory groups): groups filter and chips

367040b

Fewwy requested a review from a team as a code owner February 28, 2023 14:47

Merge remote-tracking branch 'upstream/master' into inv-table-group-f…

173da24

…ilter

Fewwy self-assigned this Mar 1, 2023

Fewwy added the enhancement New feature or request label Mar 1, 2023

Fewwy added 3 commits March 1, 2023 16:51

feat(inventory groups): working on the filter chips

75ac4ab

feat(inventory groups): fixing the chips remove

8b40d51

feat(inventory groups): updated the group filter

90f0468

Fewwy changed the title ~~DRAFT feat(invntory groups): Inv table group filter~~ feat(inventory groups): Inv table group filter Mar 7, 2023

gkarat changed the title ~~feat(inventory groups): Inv table group filter~~ feat(ESSNTL-4195): Inv table group filter Mar 7, 2023

Fewwy added 7 commits March 7, 2023 11:31

feat(inventory groups): updated the pr with fresh master

c7f1506

feat(inventory groups): fixed chips deletion and dropdown checkbox

5211d0d

Merge remote-tracking branch 'upstream/master' into inv-table-group-f…

77e2918

…ilter

feat(inventory groups): added tests and fixed a couple of inconsisten…

502b610

…cies

feat(inventory groups): adding fetch and redux store

b6b54ae

Merge remote-tracking branch 'upstream/master' into inv-table-group-f…

ad6f750

…ilter

feat(inventory groups): fixed tests

3b521fb

gkarat reviewed Mar 14, 2023

View reviewed changes

Fewwy added 2 commits March 14, 2023 15:45

Merge remote-tracking branch 'upstream/master' into inv-table-group-f…

b217cec

…ilter

feat(inventory groups): update after review

ea15674

gkarat added 3 commits March 15, 2023 10:55

Merge remote-tracking branch 'upstream/master' into inv-table-group-f…

6a613a9

…ilter

Use empty array when failed to select groups

b95a8c9

Update snapshots

5f51b37

gkarat approved these changes Mar 15, 2023

View reviewed changes

gkarat merged commit 358400e into RedHatInsights:master Mar 15, 2023

gkarat pushed a commit that referenced this pull request Mar 15, 2023

chore(release): 1.12.0 [skip ci]

ae4e163

# [1.12.0](v1.11.0...v1.12.0) (2023-03-15) ### Features * **ESSNTL-4195:** Inventory table - group filter ([#1776](#1776)) ([358400e](358400e))

gkarat added the released label Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ESSNTL-4195): Inv table group filter #1776

feat(ESSNTL-4195): Inv table group filter #1776

Fewwy commented Feb 28, 2023 •

edited

Loading

Fewwy commented Mar 13, 2023

Fewwy commented Mar 13, 2023

codecov-commenter commented Mar 13, 2023 •

edited

Loading

gkarat left a comment

gkarat Mar 14, 2023

gkarat Mar 14, 2023

gkarat commented Mar 14, 2023

Fewwy commented Mar 14, 2023

gkarat left a comment

gkarat commented Mar 15, 2023

		const { result } = renderHook(useGroupFilter, { wrapper });
		expect(result.current).toMatchSnapshot();

feat(ESSNTL-4195): Inv table group filter #1776

feat(ESSNTL-4195): Inv table group filter #1776

Conversation

Fewwy commented Feb 28, 2023 • edited Loading

Fewwy commented Mar 13, 2023

Fewwy commented Mar 13, 2023

codecov-commenter commented Mar 13, 2023 • edited Loading

Codecov Report

gkarat left a comment

Choose a reason for hiding this comment

gkarat Mar 14, 2023

Choose a reason for hiding this comment

gkarat Mar 14, 2023

Choose a reason for hiding this comment

gkarat commented Mar 14, 2023

Fewwy commented Mar 14, 2023

gkarat left a comment

Choose a reason for hiding this comment

gkarat commented Mar 15, 2023

Fewwy commented Feb 28, 2023 •

edited

Loading

codecov-commenter commented Mar 13, 2023 •

edited

Loading