Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update canonical_facts to load needed components #3448

Merged
merged 0 commits into from
Jun 23, 2022

Conversation

bfahr
Copy link
Contributor

@bfahr bfahr commented Jun 21, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Signed-off-by: Bob Fahr [email protected]

Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@psachin psachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me too.

@psachin psachin merged commit bbc2186 into master Jun 23, 2022
psachin pushed a commit that referenced this pull request Jun 23, 2022
* get_canonical_facts needs to work for legacy archives that do not include meta_data

Signed-off-by: Bob Fahr <[email protected]>
(cherry picked from commit bbc2186)
@xiangce xiangce deleted the cf_legacy_archives branch June 30, 2022 05:46
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* get_canonical_facts needs to work for legacy archives that do not include meta_data

Signed-off-by: Bob Fahr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants