FIX: Update canonical_facts to load needed components #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfahr
force-pushed
the
cf_load_components
branch
from
d0c883e to
e43610e
Compare
|
The associated issue is BZ 2097852, |
subpop
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
This LGTM. I've tested a similar change locally. Additionally, this PR branch egg has been tested by @Victoremepunto
subpop
added a commit
that referenced
this pull request
Jun 17, 2022
* For client apps that don't use insights components, this will allow them to still use get_canonical_facts for uploads Signed-off-by: Bob Fahr <[email protected]> Co-authored-by: Link Dupont <[email protected]>
3 tasks
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* For client apps that don't use insights components, this will allow them to still use get_canonical_facts for uploads Signed-off-by: Bob Fahr <[email protected]> Co-authored-by: Link Dupont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes: