Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests should not create files in protected directories #3440

Merged
merged 0 commits into from
Jun 15, 2022
Merged

Fix Tests should not create files in protected directories #3440

merged 0 commits into from
Jun 15, 2022

Conversation

ahitacat
Copy link
Contributor

Resolves: issue#3439

Signed-off-by: ahitacat [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

PR added some test that created files under the directory /var/cache/insights-client/ which is protected.

This PR mocked the creation of files in that protected directory.

@ahitacat ahitacat added the client These issues represent work to be done by the "client" team. label Jun 15, 2022
@ahitacat ahitacat requested review from subpop, strider and bfahr June 15, 2022 11:36
@ahitacat ahitacat linked an issue Jun 15, 2022 that may be closed by this pull request
@ahitacat ahitacat added the bug label Jun 15, 2022
@subpop
Copy link
Collaborator

subpop commented Jun 15, 2022

test this please

@ahitacat
Copy link
Contributor Author

test me

@subpop
Copy link
Collaborator

subpop commented Jun 15, 2022

The RHEL 6.10 failure is expected. OK to merge.

@subpop subpop merged commit 463a516 into RedHatInsights:master Jun 15, 2022
subpop pushed a commit that referenced this pull request Jun 15, 2022
@bfahr
Copy link
Contributor

bfahr commented Jun 15, 2022

Thanks @ahitacat !

xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests should not create files in protected directories
3 participants