When insights client is killed the directories in /var/tmp are not removed rhbz#2009773 #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahitacat
added
the
client
subpop
requested changes
Apr 27, 2022
insights/client/archive.py
Outdated
| try: | ||
| os.makedirs(keep_archive_dir) | ||
| except OSError as e: | ||
| logger.error(e) |
There was a problem hiding this comment.
We often get bug reports complaining about stack traces in console output. Maybe we can change this line to logger.debug? Does printing the exception here print the entire stack trace or just the exception's class & message?
There was a problem hiding this comment.
It prints the stack trace but it was a leftover of debugging it, also I have noticed the test wasn't good for this method
|
@xiangce This PR still needs review. |
Signed-off-by: ahitacat <[email protected]>
Signed-off-by: ahitacat <[email protected]>
|
@xiangce this PR is reviewed and can be merged |
xiangce
pushed a commit
that referenced
this pull request
Jun 14, 2022
…moved rhbz#2009773 (#3396) * New prefix for temp archive directory and tests Signed-off-by: ahitacat <[email protected]> * keep-archive is stored in /var/cache Signed-off-by: ahitacat <[email protected]> (cherry picked from commit d11d4e7)
3 tasks
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
…moved rhbz#2009773 (#3396) * New prefix for temp archive directory and tests Signed-off-by: ahitacat <[email protected]> * keep-archive is stored in /var/cache Signed-off-by: ahitacat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
rhbz#200973
When insights-client is killed with a SIGKILL signal, as does the
oom-killer, the directories for the archive created in/var/tmparen't removed. That leaves a lot of directories in this path, increasing the size of the/var/tmpfolder.This fix adds the following:
--keep-archivewill be storing the archive outside/var/tmp, and is up to each user to manage those stored archives