Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prod-beta to recent changes #598

Merged
merged 30 commits into from
Feb 5, 2020
Merged

Update prod-beta to recent changes #598

merged 30 commits into from
Feb 5, 2020

Conversation

karelhala
Copy link
Contributor

No description provided.

tahmidefaz and others added 30 commits January 13, 2020 16:42
#553)

* Add permission checker constants and logic to hide navigation elements

* Add tests
Co-authored-by: Karel Hala <[email protected]>
* Add documentation link for Cost Management.

* Drop OCP 4.3 version to try and default to latest OCP version.
@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #598 into prod-beta will increase coverage by 0.79%.
The diff coverage is 66.27%.

Impacted file tree graph

@@              Coverage Diff              @@
##           prod-beta     #598      +/-   ##
=============================================
+ Coverage      59.89%   60.68%   +0.79%     
=============================================
  Files             43       45       +2     
  Lines            778      842      +64     
  Branches         145      158      +13     
=============================================
+ Hits             466      511      +45     
- Misses           256      271      +15     
- Partials          56       60       +4
Impacted Files Coverage Δ
src/js/App/Sidenav/index.js 83.33% <ø> (ø) ⬆️
src/js/App/RootApp.js 100% <ø> (ø) ⬆️
src/js/entry.js 17.1% <0%> (-0.96%) ⬇️
src/js/nav/globalNav.js 96.15% <100%> (+4.48%) ⬆️
src/js/rbac/rbac.js 100% <100%> (ø)
src/js/nav/sourceOfTruth.js 18.75% <12.5%> (-11.25%) ⬇️
src/js/jwt/insights/entitlements.js 35.71% <14.28%> (-19.85%) ⬇️
src/js/rbac/fetchPermissions.js 38.46% <38.46%> (ø)
src/js/consts.js 96.15% <96%> (-3.85%) ⬇️
... and 2 more

@karelhala karelhala merged commit 6f45221 into prod-beta Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants