Get Rbac permissions

[tahmidefaz]

Jira: Here

Let me know what needs changing here! Also, not sure if I did the tests right! 😄

[codecov-io]

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files          45       45           
  Lines         801      801           
  Branches      147      147           
=======================================
  Hits          484      484           
  Misses        260      260           
  Partials       57       57

[karelhala]

When you are using next links you are essentially doing sequential requests, that can resolve into long promises. When you are going to use Promise.all each request is fired at one point and it waits for everyone to finish. There is no catch clause, so you should update the code with that.

[tahmidefaz]

@karelhala I wasn't aware of the rbac api client. Thank you for pointing it out! I just tweaked your suggestion a little bit, so that it fetches the correct count for permissions.

[karelhala]

Looking good! I checked it locally and it returns correct number of permissions and such. Really nice!

[tahmidefaz]

Looking good! I checked it locally and it returns correct number of permissions and such. Really nice!

Thanks for checking it locally! Appreciate it!

[ryelo]

I think we should clear this localStorage variable on user logout.

@karelhala thoughts?

[karelhala]

@PanSpagetka was working on some self clearing localstorage enhancements.

[tahmidefaz]

I tried quite a few things regarding the async tests without any luck. I will give it another try tomorrow. Let me know if you have any suggestions @karelhala @ryelo

[tahmidefaz]

Just added the test. Let me know if it needs to be improved.