-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add gzip-size action #767
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
869f576
to
4c7541c
Compare
Size Change: 0 B Total Size: 201 kB ℹ️ View Unchanged
|
4c7541c
to
6333c40
Compare
6333c40
to
e43f553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets Gzip To Minify
* fix: type imports * fix(audio-player): type imports * fix: pf imports * chore: reset package-lock * docs: reset footer image * feat(audio-player): CSS adjustments and pf-avatar fix * chore: reset unrelated elements * chore: update package lock * test: rename e2e file * fix(audio-player): update token values * feat(audio-player): fixes from code review in progress * feat(audio-player): lazy-loaded translation * feat(audio-player): contributor Nikki MK * feat(audio-player): working on tests * feat(audio-player): updated to @patternfly/pfe-core/controllers/roving-tabindex-controller.js * refactor(audio-player): player about * refactor(audio-player): cue code format * refactor(audio-player): menu * refactor(audio-player)!: rename menu-toggle to toggle * fix(audio-player): get slotted text in profile * refactor(audio-player)!: range event * refactor(audio-player): scrolling overflow * refactor(audio-player): subscribe * refactor(audio-player): remove non-null assertions * refactor(audio-player): remove public on prop * refactor(audio-player): transcript * refactor(audio-player): handle* => on* * feat(lib): add MicrocopyController * refactor(audio-player)!: combine templates, `on` * feat(audio-player): working on color context * feat(audio-player): fixed modes * feat(audio-player): styling fixes and demo updates * feat(audio-player): fixed issue with time slider * feat(audio-player): working on tests * test: wip test * docs: copy more media to site * test(audio-player): remove tooltip tests * test: assert on a11y tree for mute * feat(audio-player): using demo mp3s * feat(audio-player): temporarily reverting back to cdn copy of audio because of a local MIME typing issue that prevents longer audio from being seekable * feat(audio-player): preventing non-seekable audio from seeking * feat(audio-player): cue refactor with start and voice as attributes * feat(audio-player): updated download to reflect cue refactor * feat(audio-player): fixes a11y issues * feat(range): add rh-range * fix(audio-player): use rh-range * chore: temporarily patch core. REMOVE ME * chore: don't patch or husky for regular installs * feat(audio-player): fixed style of input labels * feat(audio-player): fixes issues with mute and concurrentcy * feat(audio-player): fixes to some tests * feat(audio-player): fixes ready state in testing * feat(audio-player): removes skip * feat(audio-player): fixes mute unmite test * feat(audio-player): refactored a bit but tests still timing out * feat(audio-player): addresses all of design QA except border-radius on custom color toolbars and sliders * feat(audio-player): still trying to debug tests without timeout * feat(audio-player): menu CSS from design QA * test(audio-player): update tests * fix(range): dir controller * fix(audio-player): visually hidden styles * fix(audio-player): state, formatting, context * test(audio-player): tab testing for buttons * refactor(audio-player): state, css, labels * feat(rh-menu): init rh-menu from rh-audio-player * feat(rh-menu): rh-menu is funcitonal but will need tests added * feat(rh-menu): removing rh-audio-player-menu.* * feat(menu): tests and some changes to rh-menu for audio-player * docs(rh-menu): updated demo * fix(audio player): test file is only 3s, so adjusted tests accordingly. * fix(audio player): can now seek to 0 * fix(audio player): adjusted seek tests based on a 3-second clip length * fix(audio player): accounts for full mode's two buttons labeled play (hidden or shown based on viewport) * fix(audio-player): playback-rate and stepper buttons * fix(audio-player): smaller viewport tests pass * feat(audio-player): added test for language, concurrentcy, and menu as well as fixed viewport / timing * feat(menu): css fixes * feat(audio-player): some CSS fixes * feat(audio-player): fix package-lock.json * fix(audio-player): "Failed to apply patch for package @patternfly/pfe-core at path" * docs(audio-player): changeset * docs(audio-player): updated README * docs(menu): updated README * fix(menu): fixes tests and menu close on focusout * fix(footer): warning in some frameworks (#751) * chore: prepare release (beta) (#749) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix(subnav): ensure link styles (#758) * fix(subnav): ensure link styles * chore(subnav): add changeset * docs(subnav): README.md update * fix(subnav): move active border to after psuedo element * chore: add gzip-size action (#767) * fix: remove rh-demo (#766) * fix(rh-demo): removed * fix(rh-demo): remove @lrncomponents/code-sample from declaration * fix(rh-demo): remove code-sample from eleventy config * chore: add changeset --------- Co-authored-by: Benny Powers <[email protected]> * chore: prepare release (beta) (#765) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix(range): implement without native input * docs: update changesets * style: lint * test: skip certain axe rules * test: use 1mb mp3 sample * fix(range): styles and input event * fix(audio-player): factor out state decorator * test(audio-player): resolve timing issues, etc * style: indentation * test: source order * fix(menu): make menu slot anonymous * fix: menu focus * fix(menu): rename keep to persistent * fix(DirController): handle disconnected elements * feat(audio-player): css fixes to range and menu * fix(menu)!: remove dropdown functionality * feat(audio-player): menu fixes and css fixes * feat(audio-player): renamed lightAreas prop to better descriptor hasAccentColor * feat(audio-player): set rh-range as inline-block player CSS as flex * feat(audio-player): removed unnecessary files * feat(audio-player): added warning about custom non-token colors in CSS * style: lint css * fix(audio-player): tests * docs(menu): update examples * fix(audio-player): improve i18n - use `en-US` as default language code instead of `en` - eagerly load copy for `en-US` - revamp MicrocopyController to be a map of language tables - add option to slot `<script type="application/json" data-language="${langCode}">` - Rename MicrocopyController to I18nController * fix: revert change to docs * test(menu): update tests * feat(audio-player): renamed mode to layout, added 118n lang default, fixed hidden menu z-index * feat(audio-player): CSS fixed to title and series in light dom * feat(audio-player): removed rh-range to a separate branch and fixed menu CSS * fix(audio): changed case for about panel heading and removed mp3 from detailed transcript * fix(audio-player): linting errors * fix(audio-player): fixed CSS for vertical issue in Safari * fix(audio-player): fixes escaping menu and panel as well focus when they are opened or closed * fix(audio-player): CSS linting errors * fix(audio-player): added range CSS attribution * fix(audio-player): fixed CSS linting errors for lines > 100 characters * fix(audio-player): fixed focus outline of buttons CSS * Merge branch 'main' of github.com:RedHat-UX/red-hat-design-system into feat/rh-audio-player * fix(audio-player): alligns duration to right of slider * feat(I18nController): adds async method that loads translation from a given URL * feat(audio-player): adds panel translation microcopy in Spanish * feat(audio-player): allows panel microcopy/localization to be controlled by player * fix(audio-player): makes audio-player the keeper of micropy tranlations, fixes panel accessibility, and fixes autoscroll issue when panel is opened * fix(audio-player): added aria label to download butotn * fix(audio-player): fixed transcript translation tests * fix(audio-player): set aria-label on menu items to correctly translated microcopy * fix(audio-player): fixes firefox bug with select element * demo(audio-player): fixed typo in filename * fix(menu): added element-internals-polyfill missing dependency * test(audio-player-transcript): removed aTimeout as it is not used * fix(audio-player): fixed Safari bug with tooltip positioning of play/pause button * test(menu): removed oneEvent from test since it's not being used * fix(audio-player-transcript): fixed typo for download's aria-label * fix(audio-player): fixed readystate issue on Mobile Safari * docs(audio-player): updated JS doc and cleaned up a CSS prop name * docs(audio-player): cleaned up JS doc * docs(audio-player): updates JSDoc with CSS props * fix(audio-player): fixed linting errors * fix(audio-player): fixed linting issue with delimiters * fix(audio-player): type in css * fix(audio-player): fixed linting issues * docs(menu): updated JSDocs for CSS prop for menu * docs(audio-player): removed system token CSS prop docs from elements * fix(rh-audio-player): fixed some CSS issues and some scrolling text issues * fix(audio-player): fixed demo html * fix(audio-player): fixed CSS for about section on smaller layouts * fix(audio-player): fixed CSS for about section on smaller layouts * docs(button): updated overview page * docs(button): updated @summary JSDoc * docs(button): accessibility page * docs(button): updated style, guidelines and code pages * feat(audio-player): fixed for mobile safari * feat(audio-player): fixed css props and private static vars * feat(audio-player): documented CSS props * feat(audio-player): fixed tooltip padding * feat(audio-player): fixed CSS issue on mobile safari * feat(audio-player): fixed CSS linting * feat(audio-player): mobile safari CSS and linting fixes * feat(audio-player): CSS linting * feat(audio-player): changed playback rate increments * docs(audio-player): added docs for audio-player * feat(audio-player): updated JSDoc * feat(I18nController): handled error in loading microcopy * feat(audio-player): fixes issue with detailed transcript cues * feat(I18nController): handled micropy loading errors by defaulting to en-US on error * feat(audio-player): added CSS in case lightDOM CSS isn't used * feat(audio-player): fixed transcript cue ehading levels and cue font-size * docs(audio-player): fixed demo and added profile component to code page * feat(audio-player): updated test to reflect change in playback rate step values * docs(audio-player): uploaded images * docs(audio-player): added captions and transcript WCAG links * docs(audio-player): simplified demo * docs(menu): simplified demo * test(menu): react compat * test(audio-player): react compat * chore: revert docs change to button * chore: sync package-lock * style(audio-player): remove unused variable * docs(audio-player): format demos and fix imports * docs: add noscript lightdom styles for audio-player * refactor!(audio-player): rename audio-player-cue to cue (wip) * docs(audio-player): format html * feat(heading-controller): wip migrate to context * refactor(audio-player)!: rename audio-player-transcript to transcript * fix(audio-player): improve lightdom styles * fix(audio-player): cleanup from transcript rename * style(audio-player): lint css * fix(audio-player): cue style regression * fix(audio-player): replace profile with avatar * fix(avatar): styles, whitespace * docs(avatar): nicer demo markup * refactor!: make headings controller a context * refactor: headings context followup * docs(audio-player): fix avatar usage * refactor: heading context * refactor(context): check context names * fix(audio-player): remove `has-accent-color` attribute, calculate it instead * fix(headings): calculate * fix(cue): margin for headers --------- Co-authored-by: Benny Powers <[email protected]> Co-authored-by: Benny Powers <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Steven Spriggs <[email protected]>
What I did
Testing Instructions
Notes to Reviewers