-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audio-player): add rh-audio-player #679
Conversation
🦋 Changeset detectedLatest commit: 7956ae0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…esign-system into feat/rh-audio-player
…esign-system into feat/rh-audio-player
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks fantastic. comments are mostly nits. Made it as far as HeadingController
elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.ts
Outdated
Show resolved
Hide resolved
Please run stylelint on the new css files. there are errors that aren't autofixable |
…g-tabindex-controller.js
I want to see how much we can simplify the heading controller. @nikki drop me a line when you get online and hopefully we can merge by EoD |
cdf1613
to
13e83c8
Compare
super almost there! I just want to get some clarity about <rh-audio-player accent-color="var(--rh-color-brand-red-on-light)">
<rh-audio-player accent-color="#EE0000"> I only found |
What I did
rh-menu
(based on Audio-player XD)
rh-audio-player
(based on Audio-player XD)
Closes #637 and #1072