Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audio-player): add rh-audio-player #679

Merged
merged 463 commits into from
Jun 22, 2023
Merged

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented Dec 16, 2022

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: 7956ae0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 7956ae0
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/64944d73dc43b60008356e2a
😎 Deploy Preview https://deploy-preview-679--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers changed the title Feat/rh audio player feat(audio-player): add rh-audio-player Dec 18, 2022
@nikkimk nikkimk requested a review from bennypowers February 14, 2023 16:19
@nikkimk nikkimk self-assigned this Feb 14, 2023
@nikkimk nikkimk requested a review from hellogreg February 15, 2023 16:24
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks fantastic. comments are mostly nits. Made it as far as HeadingController

elements/rh-audio-player/rh-audio-player-transcript.ts Outdated Show resolved Hide resolved
elements/rh-audio-player/rh-audio-player-transcript.ts Outdated Show resolved Hide resolved
elements/rh-audio-player/README.md Outdated Show resolved Hide resolved
elements/rh-audio-player/README.md Outdated Show resolved Hide resolved
elements/rh-audio-player/RhAudioPlayerPanelStyles.css Outdated Show resolved Hide resolved
elements/rh-audio-player/rh-audio-player-subscribe.ts Outdated Show resolved Hide resolved
elements/rh-audio-player/rh-audio-player-subscribe.ts Outdated Show resolved Hide resolved
elements/rh-audio-player/rh-audio-player-subscribe.ts Outdated Show resolved Hide resolved
elements/rh-audio-player/test/rh-audio-player.spec.ts Outdated Show resolved Hide resolved
@bennypowers bennypowers marked this pull request as ready for review February 15, 2023 16:48
@bennypowers
Copy link
Member

Please run stylelint on the new css files. there are errors that aren't autofixable

@bennypowers
Copy link
Member

I want to see how much we can simplify the heading controller. @nikki drop me a line when you get online and hopefully we can merge by EoD

@bennypowers bennypowers force-pushed the feat/rh-audio-player branch from cdf1613 to 13e83c8 Compare June 21, 2023 14:49
@bennypowers
Copy link
Member

super almost there! I just want to get some clarity about has-accent-color - can we either remove this attribute or give it a value e.g.

<rh-audio-player accent-color="var(--rh-color-brand-red-on-light)">
<rh-audio-player accent-color="#EE0000">

I only found has-accent-color in css files and the component definition, so it looks like it was intended to be set whenever users also set certain css props, is that correct?

@bennypowers bennypowers enabled auto-merge (squash) June 22, 2023 13:32
@bennypowers bennypowers merged commit b4815ae into main Jun 22, 2023
@bennypowers bennypowers deleted the feat/rh-audio-player branch June 22, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Audio player docs need review/cleanup [feat] <rh-audio-player> MVP
6 participants