Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): tab button font-size default value #1362

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Nov 27, 2023

What I did

  1. Added --rh-tabs-link-font-size to with default font-size of 1rem

Reference #1361

TODO:

  • Determine if breaking change or not, I can see it either way.

Testing Instructions

Notes to Reviewers

@zeroedin zeroedin added the bug Something isn't working label Nov 27, 2023
@zeroedin zeroedin self-assigned this Nov 27, 2023
@zeroedin zeroedin marked this pull request as draft November 27, 2023 20:10
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: 06fb4b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 06fb4b4
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6566094243ea390008676837
😎 Deploy Preview https://deploy-preview-1362--red-hat-design-system.netlify.app/elements/tabs/code
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Size Change: +17 B (0%)

Total Size: 210 kB

Filename Size Change
./elements/rh-tabs/rh-tabs.js 1.88 kB +20 B (+1%)
./rhds.min.js 82 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.27 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.91 kB
./elements/rh-badge/rh-badge.js 1.01 kB
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 4.39 kB
./elements/rh-card/rh-card.js 1.94 kB
./elements/rh-code-block/rh-code-block.js 1.19 kB
./elements/rh-context-provider/rh-context-provider.js 189 B
./elements/rh-cta/rh-cta.js 4.58 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.08 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.25 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.57 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.41 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.46 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-table/rh-sort-button.js 1.31 kB
./elements/rh-table/rh-table.js 2.29 kB
./elements/rh-tabs/rh-tab-panel.js 788 B
./elements/rh-tabs/rh-tab.js 1.83 kB
./elements/rh-tag/rh-tag.js 1.96 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-tile/rh-tile.js 4.2 kB
./elements/rh-timestamp/rh-timestamp.js 974 B
./elements/rh-tooltip/rh-tooltip.js 2.24 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.14 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.41 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B

compressed-size-action

@zeroedin zeroedin changed the title fix(tabs)!: tab button font-size should be set to 16px fix(tabs)!: tab button font-size default value Nov 27, 2023
Copy link
Collaborator

@marionnegp marionnegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Levitating Gnomes Travel Merrily

Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Generators Trivialize Merges

Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead just set rh-tab's font size on rh-tabs, no opostrophe. if slotted specificity is a thing, then fix it in ux-dot

@bennypowers bennypowers changed the title fix(tabs)!: tab button font-size default value fix(tabs): tab button font-size default value Nov 28, 2023
@bennypowers
Copy link
Member

preemptively approving based on gchat dms

@zeroedin zeroedin marked this pull request as ready for review November 28, 2023 15:41
@zeroedin zeroedin enabled auto-merge (squash) November 28, 2023 15:42
@zeroedin zeroedin disabled auto-merge November 28, 2023 15:42
@zeroedin zeroedin enabled auto-merge (squash) November 28, 2023 15:44
@zeroedin zeroedin disabled auto-merge November 28, 2023 15:44
@zeroedin zeroedin enabled auto-merge (squash) November 28, 2023 15:45
@zeroedin zeroedin merged commit a6510e2 into main Nov 28, 2023
10 of 11 checks passed
@zeroedin zeroedin deleted the fix/tabs/tab-font-size branch November 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

4 participants