Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] "Installation" section's tab panel width #1361

Closed
marionnegp opened this issue Nov 27, 2023 · 2 comments · Fixed by #1366
Closed

[bug] "Installation" section's tab panel width #1361

marionnegp opened this issue Nov 27, 2023 · 2 comments · Fixed by #1366
Labels
bug Something isn't working needs prioritization This issue needs prioritization

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

The "Installation" section of any element's "Code" subpage is too wide and is adding horizontal scroll. The tab font size also looks larger than it should be.

Should this be an update to <rh-tabs>?

Which Component?

rh-tabs

Steps to reproduce

An example can be found on the audio player's page.

Expected behaviour

The tabs + tab panel should have the same width as the rest of the page's content.

Screenshots

Screenshot 2023-11-27 at 11 09 23 AM

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response

@marionnegp marionnegp added bug Something isn't working needs prioritization This issue needs prioritization labels Nov 27, 2023
@zeroedin
Copy link
Collaborator

zeroedin commented Nov 27, 2023

Should this be an update to <rh-tabs>?

Looks like it yes.

pf-tabs sets its own CSS value font-size: var(--pf-c-tabs__link--FontSize, var(--pf-global--FontSize--md, 1rem));

Assuming we want the similar idea using @rhds/token values and that only the tab buttons themselves get the font-size value?

Do you want to set a font-size on the panel or does it remain inherit?

``

@marionnegp
Copy link
Collaborator Author

@zeroedin, yeah, I think only the tab buttons should get the font-size value. Makes sense to let the panel's font size inherit.

bennypowers added a commit that referenced this issue Dec 3, 2023
bennypowers added a commit that referenced this issue Dec 5, 2023
* docs: code installation tabs

Fixes #1361

* docs: hack a fix for install tabs

* docs: fix another careless error

* docs: doh
@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Dec 5, 2023
bennypowers added a commit that referenced this issue Dec 6, 2023
* docs: code installation tabs

Fixes #1361

* docs: hack a fix for install tabs

* docs: fix another careless error

* docs: doh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs prioritization This issue needs prioritization
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

2 participants