-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): vertical alignment of footer #1315
Conversation
🦋 Changeset detectedLatest commit: 476732c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +13 B (0%) Total Size: 209 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The footer does look like it's anchoring to the bottom. This might be a dumb question, but how would I test it in different contexts "with proxy"?
The spacing between each section is off. The header's padding is correct, but the body and footer's padding-block
should be changed based on the image below.
@marionnegp do you mean that the footer content should appear further up the card? if so then let's close this PR, which is about aligning the footer content to the bottom of the card in a grid, regardless of the specific content height of each card |
I'll open a new issue to fix spacing. The footer did stick to the bottom, even when I added more content to the body of one card. I only checked this in card's grid demo. Should I check anywhere else to make sure it works? |
Added a new issue to fix |
that one demo file (grid.html) is the only one you need to check here, i think So if this is good, let's approve-and-merge |
What I did
Testing Instructions
Notes to Reviewers