Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-card> padding #1324

Closed
marionnegp opened this issue Nov 8, 2023 · 1 comment · Fixed by #1326
Closed

[bug] <rh-card> padding #1324

marionnegp opened this issue Nov 8, 2023 · 1 comment · Fixed by #1326
Labels
bug Something isn't working

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

The block padding for card's body and footer needs to be adjusted. Right now the space between the body and footer is 64px because of padding in both sections. The space between the body and footer should be 24px (--rh-space-xl).

Additionally, can the padding-inline of header be changed to --rh-space-2xl? It'll help the content in the header align with the rest of the content.

Which Component?

rh-card

Steps to reproduce

  1. Pull up a demo of card.
  2. Check to see if padding matches screenshots below.

Expected behaviour

The space between the body and footer should be 24px (--rh-space-2xl). Inline padding of header should change to 32px (--rh-space-2xl).

Screenshots

Current padding/spacing:

Screenshot 2023-11-08 at 9 26 29 AM

Screenshot 2023-11-08 at 9 26 35 AM

Expected spacing:

Screenshot 2023-11-01 at 11 32 03 AM

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response

@bennypowers
Copy link
Member

i see now, so this maybe could be solved with margin-trim, which is experimental

but in the mean time we can work this out maximum with empty classes and some oldschool css

bennypowers added a commit that referenced this issue Nov 9, 2023
bennypowers added a commit that referenced this issue Nov 16, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

2 participants