-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relate quote to orders #1866
Draft
lexerom
wants to merge
25
commits into
main
Choose a base branch
from
use-order-for-quotes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Relate quote to orders #1866
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b57879b
Relate quote to orders
lexerom 211c65c
Update openapi/components/schemas/QuoteCreateOrder.yaml
lexerom e93a22d
Update quotes with order items properties
lexerom 719d314
Merge branch 'use-order-for-quotes' of github.com:Rebilly/api-definit…
lexerom 326c28d
Add readonly for create quote
lexerom 1a14746
Fix trial conversion
lexerom d21bf37
Move properties to order
lexerom 7ce9329
Add trial conversion
lexerom 08d51e1
Change property names
lexerom 47c5536
fix quoteItemId
lexerom 7f3eb13
Set default quantity to 1
lexerom f0f5fab
Refactor quote items, add type instead of action
lexerom f270d1b
Remove unused file
lexerom db5ee53
Fix trial conversion
lexerom 9ca53fc
Remove required section from storefront
lexerom 1600ecc
Remove embedded for quote order item
lexerom 2d8ee8b
Update openapi/components/schemas/QuoteCreateOrder.yaml
lexerom c34e4a0
Merge branch 'main' into use-order-for-quotes
lexerom e50cb34
Rename order to orderChanges
lexerom 44fdc30
Make orderId required, remove readOnly
lexerom 2eb6b0a
Merge branch 'main' into use-order-for-quotes
lexerom 79cebb1
Apply suggestions from code review
lexerom 55a8baf
Merge branch 'main' into use-order-for-quotes
lexerom f6c612e
Apply suggestions
lexerom d15bf5f
Merge branch 'use-order-for-quotes' of github.com:Rebilly/api-definit…
lexerom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
allOf: | ||
- $ref: ./QuoteOrderItem.yaml | ||
- type: object | ||
properties: | ||
renewalPolicy: | ||
description: Specifies if the subscription retains its current `renewalTime` or resets it to a newly calculated `renewalTime`. | ||
type: string | ||
default: retain | ||
enum: | ||
- reset | ||
- retain | ||
prorated: | ||
description: |- | ||
Specifies whether to give a pro rata credit for the amount of time remaining between the `effectiveTime` and the end of the current period. | ||
|
||
In addition, if the `renewalTime` is retained, by setting the `renewalPolicy` to `retain`, | ||
a pro rata debit occurs for the amount between the `effectiveTime` and the `renewalTime` as a percentage of the normal period length. | ||
type: boolean | ||
default: true | ||
effectiveTime: | ||
description: |- | ||
Date from which the renewal time for `reset` operations and proration calculations are made. | ||
If this field is omitted, this value defaults to the time of quote acceptance. | ||
type: | ||
- 'string' | ||
- 'null' | ||
format: date-time | ||
keepTrial: | ||
description: |- | ||
Specifies if the subscription order must retain its active trial. | ||
This field is only applicable if `renewalPolicy` is set to `retain`. | ||
type: boolean | ||
default: false | ||
interimOnly: | ||
type: boolean | ||
default: true | ||
description: |- | ||
Specifies if the quotation invoice must include interim items only. | ||
If this value is set to `false`, all upcoming items are included. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right this object is the same across all the files? If so, we need it to be extracted and reused as it's quite big and hard to manage otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved similar code of items into files.